ChartsOrg / Charts

Beautiful charts for iOS/tvOS/OSX! The Apple side of the crossplatform MPAndroidChart.
Apache License 2.0
27.51k stars 5.99k forks source link

Stronger Testing Procedures #4132

Open caloon opened 5 years ago

caloon commented 5 years ago

This is not a specific issue, but more of a general feedback. I am a big fan of this repository and have been since the very early days. However, it is my impression that changes to the code base, especially pull requests submitted by the community, are accepted without applying strong testing procedures. I'd like to make the case for this by explaining my situation:

As a result, version 3.2.1 is the last stable release which is suitable for use in my app.

liuxuan30 commented 5 years ago

We have UT and CI, and I would apology for the issue.

But asking every PR to include UT sounds a little unrealistic. And some PRs are just hard to have a UT, like animation or some other changes, somehow it escape our UT.

Thanks for your support, I will try to take a look at issues you mentioned.