Marker view mac - Githubissues

ChartsOrg / Charts

Beautiful charts for iOS/tvOS/OSX! The Apple side of the crossplatform MPAndroidChart.

Apache License 2.0

27.51k stars 5.99k forks source link

Marker view mac #5030

Open RCCoop opened 1 year ago

RCCoop commented 1 year ago

Issue Link :link:

https://github.com/danielgindi/Charts/issues/5023

Goals :soccer:

Make MarkerView work in MacOS, and add an example of it into the MacOS sample app.

Implementation Details :construction:

Several non-breaking changes in MarkerView
- Added didSet in chartView property, which calls a new function didAddToChart(_:).
- didAddToChart(_:) only does anything in OSX. It adds the MarkerView as an off-screen subview of the chartView's containing view. This is necessary because the MarkerView would not render in OSX without it having been added to a view already. See this SO answer for more context.
- Changed the implementation of viewFromXib(in:) to return Self rather than MarkerView so that subclasses will return as their own type rather than the base class.
- Also changed the implementation of viewFromXib(in:) to find the first instance of Self in the loaded objects from the xib rather than assuming that the first object in that array was the one we'd be looking for. In MacOS this was a problem because the view was often second in the xib's loaded objects rather than the first.
- Finally, in the MacOS implementation of viewFromXib(in:), set wantsLayer to true for the resulting view, which was also necessary to render the view during draw(context:point:) as referenced in previous StackOverflow answer.

Testing Details :mag:

Created RadarMarkerViewMac in the MacOS sample app, which is nearly identical to the RadarMarkerView in the iOS sample app.
Added the new RadarMarkerViewMac as the marker in the MacOS sample's RadarDemoViewController.
Ran the MacOS sample app and made sure the RadarDemoViewController displayed the marker as expected.

yongfrank commented 9 months ago

Thank you for your commit. It very useful for me to develop with DGCharts on Mac!

It's strange that your PR fixing the bug has not been merged for a long time.

yongfrank commented 9 months ago

@liuxuan30 Hi, I found the same issue with Marker View and xib on Mac when I was developing. #5023