search

ChartsOrg / Charts

Beautiful charts for iOS/tvOS/OSX! The Apple side of the crossplatform MPAndroidChart.
Apache License 2.0
27.59k stars 6k forks source link

Fix Node 12 deprecation warning #5043

Closed FelixHerrmann closed 1 year ago

FelixHerrmann commented 1 year ago

Goals :soccer:

The GitHub checkout action v2 uses Node.js 12. This version of Node is deprecated and will be fully removed in summer 2023, see this blog post.

Screenshot 2023-04-10 at 15 55 30

Implementation Details :construction:

I have updated all checkout actions to us v3 instead of v2.

Testing Details :mag:

I couldn't test it with this repo, but I have not experienced any issues with the other workflows where I have done the upgrade.

Edit: CI is not failing and the warnings are gone: https://github.com/danielgindi/Charts/actions/runs/4658235640

pmairoldi commented 1 year ago

Nice catch. Thanks.