search

ChartsOrg / Charts

Beautiful charts for iOS/tvOS/OSX! The Apple side of the crossplatform MPAndroidChart.
Apache License 2.0
27.51k stars 5.99k forks source link

remove swift-algorithms package in favor of manully importing needed … #5069

Closed pmairoldi closed 1 year ago

pmairoldi commented 1 year ago

Removed the need for swift-algorithms.

We were using only 2 functions so I duplicated the source code into our codebase. We now own this and do not have dependencies.

Addresses #4919 & #4938

liuxuan30 commented 1 year ago

@pmairoldi, just asking, it seems builds fine, are you having problems still and have to remove the packages?

pmairoldi commented 1 year ago

Don't think so. I removed everything.

liuxuan30 commented 1 year ago

what don't compile?

pmairoldi commented 1 year ago

Nothing but it's more to fix the Bitcode and build for distribution errors. We use only 2 functions. I'd rather own the code than have a dependency for such a small thing.