Support for rounded bar chart and grid edges

ChartsOrg / Charts

Beautiful charts for iOS/tvOS/OSX! The Apple side of the crossplatform MPAndroidChart.

Apache License 2.0

27.48k stars 5.98k forks source link

Open swatiyadav009 opened 10 months ago

swatiyadav009 commented 10 months ago

swatiyadav009 commented 10 months ago

Please do check my open PR for rounded slices for PieChart as well. Link - https://github.com/danielgindi/Charts/pull/5114

gabors commented 8 months ago

@swatiyadav009 Love this PR, few comments / wishes however:

the corner radius is a percentage of the bar width, so it doesn't work for horizontal charts, as they end up with super rounded corners (see example, dataSet.cornerRadius = 0.1)
would it be possible to supply instead an absolute value for the corner radius in points?

crash481 commented 4 months ago

1) bottom of Bars also with CornerRadius, when usually it is only on top. Need to make for every edge 2) Selection highlight without corners

gabors commented 4 months ago

I actually don't mind the rounded edges on the bottom but yes the lack of rounding on the highlighted back has been annoying.

crash481 commented 4 months ago

@gabors it is popular design when bars in bottom starts without corner radius, and on the top corners is rounded

crash481 commented 4 months ago

I made this pull request, both problems above is fixed https://github.com/ChartsOrg/Charts/pull/5163

gabors commented 4 months ago

Agreed it's better to have options.

crash481 commented 4 months ago

@gabors oh, also your wish about implement corner radius in absolute values also there. ✌️

gabors commented 4 months ago

@crash481 amazing. I can get rid of my fork then 😊

I'll test it out today. Thanks 🙏

gabors commented 4 months ago

@crash481 on a different subject. How did you add that popup value ?