search

ChasakisD / XFShimmerLayout

Efficient way to add a shimmering effect to your Xamarin.Forms applications.
Apache License 2.0
53 stars 12 forks source link

Round corners #7

Closed VasenevEA closed 5 years ago

VasenevEA commented 5 years ago

Hi! What do you think about this feature?

I think, if I need to use round corners when Shimmer Animation is active, but I dont want to add frame around every label(for example), and this is no good :)

You can set default CornerRadius and padding of overlay for every element,

<controls:ShimmerLayout 
 CornerRadiusOverlayDefault="10"
 PaddingOverlayDefault="5" />

or set for single element using Attached Property

<controls:ShimmerLayout ... >
<BoxView 
         controls:ShimmerLayout.PaddingOverlay="7,1"
         controls:ShimmerLayout.CornerRadiusOverlay="5"
         ... />
</controls:ShimmerLayout>
VasenevEA commented 5 years ago

I was check out the comments, and modified code

ChasakisD commented 5 years ago

@VasenevEA Thanks for the PR :)