search

Chasmiccoder / Algos-for-Amigos

This repository consists an implementation of the Algorithms encountered in Computer Science, Physics and Mathematics.
MIT License
17 stars 5 forks source link

Created counting sort algorithm. #4

Closed lolzone13 closed 3 years ago

lolzone13 commented 3 years ago

Let me know if there are any changes to be made.

Chasmiccoder commented 3 years ago

Whoa, nice. The code looks good, and makes sense. Output is also correct.. Just one thing, can you remove the extra newlines? For example, between lines 19, 22; 64,67; I think in the usual coding convention, there are 2 lines between functions.

Chasmiccoder commented 3 years ago

Also, one more thing.. I think the filename is incorrect. In the README file, I think the number 3 was assigned to Counting Sort. This does not really matter, but p1_ is already taken by bubble sort, so yea.

lolzone13 commented 3 years ago

Yeah, I'll fix it and create a PR.