I'm interested in implementing support for Windows

Chassis / puppet-wp

This module enables the easy use of WP CLI to control your WordPress site through Puppet manifests

https://chassis.github.io/puppet-wp/

GNU Lesser General Public License v3.0

44 stars 39 forks source link

I'm interested in implementing support for Windows #140

Closed JohnEricson closed 3 years ago

JohnEricson commented 3 years ago

Hi @BronsonQuick! It seems this module doesn't fully support Windows. I see installing the phar-file requires /usr/bin/curl among others on this line https://github.com/Chassis/puppet-wp/blob/master/manifests/cli.pp#L18 . I'm interested in implementing this in your module. If I send you a pull request would you be interested in merging it?

BronsonQuick commented 3 years ago

Hey @JohnEricson, ahh yes. We definitely hadn't considered Windows users looking at that. I'd definitely been keen for a PR from you for Windows support! Thanks

JohnEricson commented 3 years ago

Great! I'll let you know when I have it ready! 🙂

BronsonQuick commented 3 years ago

Fixed via: https://github.com/Chassis/puppet-wp/pull/141 💖