search

Chassis / vip_classic

2 stars 1 forks source link

vagrant provision fails if cloned with a different folder name #11

Closed mikeselander closed 6 years ago

mikeselander commented 7 years ago

If you clone out the vip-classic extension with any other folder name than vip-classic then vagrant provision will fail on this line: https://github.com/Chassis/vip-classic/blob/master/modules/vip/manifests/init.pp#L4

It might be a bit of an edge case, but that static folder name feels a bit like a magic number and makes the setup more fragile then it should be imho.

stuartshields commented 7 years ago

@mikeselander Other Extensions within Chassis work the same way. I'm not sure if this is really an issue? It's part of the install steps to use that particular extension name.

stuartshields commented 7 years ago

@mikeselander Don't mind me. I'll fix this tonight.

mikeselander commented 7 years ago

Thanks Stuart :)

To be fair, you're totally right that it's not an issue strictly - it would just be nice to have a more flexible structure in case someone chooses a different name to clone down...

rmccue commented 7 years ago

FWIW, this behaviour will be enshrined into Chassis with v2 of the extensions API, since the class name will have to match the extension name.

stuartshields commented 7 years ago

@mikeselander See @rmccue comments above.

mikeselander commented 7 years ago

@stuartshields yes, I saw the above.

BronsonQuick commented 6 years ago

I'm closing this issue as I'm adding in https://github.com/Chassis/vip-classic/issues/16 so we won't be able to fix this.