Build portability images for VTK 9.x

kwabenantim commented 11 months ago

Description We would like to run regular Chaste portability tests with VTK 9.0.x and 9.1.x.

Potential solutions:

Rebuild two existing portability images and replace the VTK versions with 9.0.x and 9.1.x. This is feasible as 7.1.x and 8.2.x are repeated in the current image set.
Create new portability images and tests for the new VTK versions.

Related Issues

https://github.com/Chaste/Chaste/issues/36

To Do

[x] Build portability image with VTK 9.0.x
[x] Build portability image with VTK 9.1.x

kwabenantim commented 11 months ago

Planned Changes to Portability Images Before .	01	02	03	04	05
VTK	6.3.0	7.1.1	7.1.1	8.2.0	8.2.0

After .	01	02	03	04	05
VTK	6.3.0	7.1.1	9.0.3	8.2.0	9.1.0

kwabenantim commented 11 months ago

VTK 9.0.3 build fails:

#10 981.5 In file included from /home/runner/modules/src/vtk/VTK-9.0.3/Common/Core/vtkGenericDataArray.h:72,
#10 981.5                  from /home/runner/modules/src/vtk/VTK-9.0.3/Common/Core/vtkGenericDataArray.cxx:25:
#10 981.5 /home/runner/modules/src/vtk/VTK-9.0.3/Common/Core/vtkGenericDataArrayLookupHelper.h: In function 'bool detail::isnan(T)':
#10 981.5 /home/runner/modules/src/vtk/VTK-9.0.3/Common/Core/vtkGenericDataArrayLookupHelper.h:52:26: error: 'numeric_limits' is not a member of 'std'
#10 981.5    52 |   return has_NaN<T, std::numeric_limits<T>::has_quiet_NaN>::isnan(x);
#10 981.5       |                          ^~~~~~~~~~~~~~
#10 981.5 /home/runner/modules/src/vtk/VTK-9.0.3/Common/Core/vtkGenericDataArrayLookupHelper.h:52:26: error: 'numeric_limits' is not a member of 'std'
#10 981.5 /home/runner/modules/src/vtk/VTK-9.0.3/Common/Core/vtkGenericDataArrayLookupHelper.h:52:42: error: template argument 2 is invalid
#10 981.5    52 |   return has_NaN<T, std::numeric_limits<T>::has_quiet_NaN>::isnan(x);
#10 981.5       |                                          ^
#10 981.7 In file included from /home/runner/modules/src/vtk/VTK-9.0.3/Common/Core/vtkGenericDataArray.cxx:27:
#10 981.7 /home/runner/modules/src/vtk/VTK-9.0.3/Common/Core/vtkDataArrayPrivate.txx: In function 'bool vtkDataArrayPrivate::detail::isinf(T)':
#10 981.7 /home/runner/modules/src/vtk/VTK-9.0.3/Common/Core/vtkDataArrayPrivate.txx:97:31: error: 'numeric_limits' is not a member of 'std'
#10 981.7    97 |   return has_infinity<T, std::numeric_limits<T>::has_infinity>::isinf(x);
#10 981.7       |                               ^~~~~~~~~~~~~~
#10 981.7 /home/runner/modules/src/vtk/VTK-9.0.3/Common/Core/vtkDataArrayPrivate.txx:97:31: error: 'numeric_limits' is not a member of 'std'
#10 981.7 /home/runner/modules/src/vtk/VTK-9.0.3/Common/Core/vtkDataArrayPrivate.txx:97:47: error: template argument 2 is invalid
#10 981.7    97 |   return has_infinity<T, std::numeric_limits<T>::has_infinity>::isinf(x);
#10 981.7       |

fcooper8472 commented 11 months ago

Looks as though it's missing the <limits> header....

kwabenantim commented 11 months ago

Looks as though it's missing the <limits> header....

Thanks @fcooper8472. I'll make a patch for it.

kwabenantim commented 11 months ago

Possibly some useful patches here too: https://sources.debian.org/patches/vtk9/

kwabenantim commented 11 months ago

The chaste/runner:jammy.portability-05 docker image now has VTK 9.1.0.

kwabenantim commented 11 months ago

The chaste/runner:jammy.portability-03 docker image now has VTK 9.0.3.

Chaste / dependency-modules

Build portability images for VTK 9.x #51