Issue#9 implement user profile screen

ChatAir / ChatAir-android

🔥 A highly advance featured chat app in android using Firestore

Apache License 2.0

178 stars 33 forks source link

Issue#9 implement user profile screen #15

Closed killbotXD closed 4 years ago

killbotXD commented 4 years ago

Description

implemented user profile screen

Type of Changes?

Just put an x in the [ ] which are valid.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Testing Suites

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

[ ] ./gradlew assembleDebug assembleRelease

Checklist:

[ ] My code follows the style guidelines of this project
[x ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings

AminullahTajMuhammad commented 4 years ago

@killbotXD thanks for your contribution, can you change the ActionBar color and also change the title of ActionBar as given in designs.

killbotXD commented 4 years ago

@AminullahTajMuhammad I have made all the requested changes please review

AminullahTajMuhammad commented 4 years ago

add a gif/Screenshot of Profile Screen UI

killbotXD commented 4 years ago

updated the screenshot in the description

killbotXD commented 4 years ago

@AminullahTajMuhammad please review

killbotXD commented 4 years ago

@iadeelzafar made requested changes.

iadeelzafar commented 4 years ago

@killbotXD Is this design responsive on multiple screens? Have you checked it on more than one devices with different screen sizes? I would suggest you to please verify if this design is responsive by testing it on multiple devices with different screen sizes and then let us know.

killbotXD commented 4 years ago

@iadeelzafar I checked on 3 devices the design looks fine to me. I changed the code style also as specified.

iadeelzafar commented 4 years ago

@killbotXD Please don't add commit messages like made requested changes Instead write what changes were made. For example: Removed blank spaces and corrected string values Commit messages must be treated very carefully. Hope this helps next time.

killbotXD commented 4 years ago

@iadeelzafar apologies. I will make sure that I am more specific from next time.

What are my objectives now?

killbotXD commented 4 years ago

@iadeelzafar please respond

iadeelzafar commented 4 years ago

@killbotXD please make the required changes so that we can merge this PR.

killbotXD commented 4 years ago

@iadeelzafar @AminullahTajMuhammad apologies for not making changes. I had my midsemster exams this week. I will try to make changes Asap.