Add new login screen

[alistairholmes]

5

• Create new login screen

Type of Changes?

Just put an x in the [ ] which are valid.

• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] Testing Suites

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

• [x] ./gradlew assembleDebug assembleRelease

Checklist:

• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings

[AminullahTajMuhammad]

@alistairholmes Thanks for your contribution. Can you please add a screenshot of UI.

[alistairholmes]

[AminullahTajMuhammad]

@alistairholmes

Here are few things you have to change

• Remove the space between Remember me and Password Field.
• Buttons text should be in small letters.

Make sure that this ui should be responsive. You have to check it on multiple screen with different sizes.

[alistairholmes]

Okay, just to make sure I understand. You want it to be tv_rememberme and passwordfield?

[AminullahTajMuhammad]

you have to remove this space

[alistairholmes]

Tried my best to reduce the space as much as possible. Will send screenshot.

[alistairholmes]

[alistairholmes]

@AminullahTajMuhammad @iadeelzafar Let me know your thoughts. Also wanted to find out if I could be added to the organisation so that could help out in the future :wink:

[alistairholmes]

[alistairholmes]

@iadeelzafar The G logo is set to drawableLeft for the button, as a result it is in line with the text. If I center the logo, then the text goes back to the bottom. In the previous screen the logo was centered.

[AminullahTajMuhammad]

@alistairholmes Don't Use width hardcoded, Set the contraints of it. You set the Width 320dp but if we run this app on Tablet then it would be smaller. That's why I told you that this UI could not be responsive.

[alistairholmes]

@AminullahTajMuhammad okay, I understand. Please provide a suggestion so that I can achieve that. It's either I make the views match_parent or wrap_content but that destroys the whole layout.

[YassinAJDI]

@alistairholmes you can make it match parent or match constraint in case of constraint layout. and give it margins on both sides

[alistairholmes]