search

ChatSecure / ChatSecure-iOS

ChatSecure is a free and open source encrypted chat client for iOS that supports OTR and OMEMO encryption over XMPP.
https://chatsecure.org
Other
3.13k stars 1.03k forks source link

Handle invalid OMEMO bundles better: invalid signature on device key #725

Open chrisballinger opened 7 years ago

chrisballinger commented 7 years ago

Somehow it's possible to publish an invalid bundle, but there's not a good way to know that other people are having trouble parsing it. We need a way to:

afriedmanGlacier commented 7 years ago

@chrisballinger, do you know where it fails when this (invalid bundle) happens? Right now, sometimes it fails for us in fetching the bundle for a device id, but other times it fails in getting a chain_key (I'm not sure what that is) in session_cipher.c, which causes SignalSessionCipher.encryptData to return nil and OTROMEMOSignalCoordinator.encryptAndSendMessage to return nil.

chrisballinger commented 7 years ago

Here's an example of a prekey bundle that fails.

<iq xmlns="jabber:client" id="F0D665E8-FE0F-4F28-9388-6F1F448C0E47" type="result" to="alice@example.com/chatsecure63531" from="bob@example.com">
  <pubsub xmlns="http://jabber.org/protocol/pubsub">
    <items node="eu.siacs.conversations.axolotl.bundles:1364390939">
      <item id="1">
        <bundle xmlns="eu.siacs.conversations.axolotl">
          <signedPreKeyPublic signedPreKeyId="1934732210">Bc9TOYv2lM63DQrSeLZUSe1M6JduulYIAnfLF0DZJI5V</signedPreKeyPublic>
          <signedPreKeySignature>eeW/q6ZVdF+uIfEMT/VnEEHmqc9zp9lfS7OST8q+C6gjSF5Vd/5tTPfvwPQsBgEFSj+Vy2+bu4Hmw3mJtSAniw==</signedPreKeySignature>
          <identityKey>Bd/9tSfIPPZiHYXfxYFfvuDNLZiu3F+/ZG7C8iOJoIxE</identityKey>
          <prekeys>
            <preKeyPublic preKeyId="17">BVgol2k9D89w1KX+3La4t45/pZFq+T2jJLmihj+MU+cY</preKeyPublic>
            <preKeyPublic preKeyId="14">BegAUQXMjjRYqAQ2invDfoPAHTmTTzDdaMavruMIfPdZ</preKeyPublic>
            <preKeyPublic preKeyId="30">BVNm2Jld7AFJWf4v+wEoJMoz6T8YJPMklDttxbxbZjxc</preKeyPublic>
            <preKeyPublic preKeyId="77">BXjfnhp3yKcZz2kN2n8eYmnsuQ8tdyxQedcEsP8UB0Ir</preKeyPublic>
            <preKeyPublic preKeyId="68">BRFR0zgNGzQdCGviFhtIHgURIzJInu5NyUeU8gzjMsYx</preKeyPublic>
            <preKeyPublic preKeyId="99">BSkS2RHa22KOhWPLNyxim8J8EULwFoMJkcCkw6fk0qM/</preKeyPublic>
            <preKeyPublic preKeyId="3">BVf0/9NEk+w4uLIt3Af2KVl2meZK5MUdbcsNO211+dRa</preKeyPublic>
            <preKeyPublic preKeyId="32">BQanIevASxDSFbwi87IAQHV3eE33q1NXxzzqj7qeh08d</preKeyPublic>
            <preKeyPublic preKeyId="58">BQPV18k9fkxwiyrVIlkek5UoJQGHxTUL42D/U6BMnP9o</preKeyPublic>
            <preKeyPublic preKeyId="28">BcW5PH9ozMAw3ceX4J2ML1ZToZhuYumwFoD3i6MOQGEW</preKeyPublic>
            <preKeyPublic preKeyId="84">BXpE4jXrbbQ+J4A/o70R1BkfAO/cqgOeCGtKYTyU7YMP</preKeyPublic>
            <preKeyPublic preKeyId="6">BXwsAI6fUixM7Op2mk1vXfDt1MxkrfhrSu8NWgWc8OhM</preKeyPublic>
            <preKeyPublic preKeyId="50">BYXpDs0SQ6qK9+nDP4v8gkK73ftXXYhAmZVlXTl2tL0o</preKeyPublic>
            <preKeyPublic preKeyId="12">BYE3OgiOMbO1hISoMpTeWevqRiKKaPjNGpsMT0OIDAEI</preKeyPublic>
            <preKeyPublic preKeyId="23">BXhYwuh1lINDsvMbM3fli5N7u7gZtrdDxX5EDv9UDtcd</preKeyPublic>
            <preKeyPublic preKeyId="25">BRH1cZn8bQ0Ts50Bs2sv7Baudt0G9a2Vsq1TnZQiO6Eo</preKeyPublic>
            <preKeyPublic preKeyId="90">BXlPH29mvyGgXxVu3RPoAUHI816vEfYswF/9v17mP2FN</preKeyPublic>
            <preKeyPublic preKeyId="5">BTHMg4Ez8YKR882Ov7jq6OXLgsrvxh6JNk1/64hrMu1X</preKeyPublic>
            <preKeyPublic preKeyId="78">BbclBwL7gVgrrTO4ZwYEsydsoMjIIrnOxk5mZOSn839Y</preKeyPublic>
            <preKeyPublic preKeyId="45">BUlt2QKpAfp8LbnHRKMNieCWOGUUg+u7ISASW7CoLn0a</preKeyPublic>
            <preKeyPublic preKeyId="63">BVqgeffrJJpaJ4vnV8PzXPRuX32EkpR5aQZZX6yLhUEc</preKeyPublic>
            <preKeyPublic preKeyId="11">BcMgvAiaFf1bKJiQi/l9R32ljUlVLuZt2+MM4R99XoIt</preKeyPublic>
            <preKeyPublic preKeyId="37">Bf49TxkGy6PYu7TZ5l5H2ofJ4dqxjXsj4bSFZ1WbCvEe</preKeyPublic>
            <preKeyPublic preKeyId="2">BS/T8qMafufISTq+79Yk3n0m4T7Eux6hkuc2NT2A+s1/</preKeyPublic>
            <preKeyPublic preKeyId="98">Bdbk28yWm9YXpxFD7gPn4wlsMu4OFr6kR68jXjBzM00i</preKeyPublic>
            <preKeyPublic preKeyId="27">BV1n/AAfxZpY/plZXR3ATJHDfryvMeaB4UucdVhlJkFr</preKeyPublic>
            <preKeyPublic preKeyId="71">BbL8GqqlDS8F4RsXNvcvlDfw1j/3knvhh8/ysO75qboh</preKeyPublic>
            <preKeyPublic preKeyId="87">BR0NlJd2MosLrcZ09TbPoF1bKqENq2P0qGgoWxKq638h</preKeyPublic>
            <preKeyPublic preKeyId="76">BfZ4TPSHEaRn4aZMdQnR/Nim7yEg5lkDXvZzkXqq29Ne</preKeyPublic>
            <preKeyPublic preKeyId="21">BZSzrssHvJtuLh3mxQzSQey7J0JTUi1Hd/mHAWA+3JUA</preKeyPublic>
            <preKeyPublic preKeyId="9">BYODpcPqBYamzvuRGjNy1mA1dAn3sB6Q2nqSBGUadKhS</preKeyPublic>
            <preKeyPublic preKeyId="44">BUqk4NVjWvDzZnJvX6Ez6cGIIPGz+9Aczg4E3Wjcank9</preKeyPublic>
            <preKeyPublic preKeyId="35">Bfiq5tU7ogqWJm8k2Y4o9oXGzuoNhhBWav2a/iBD7RQ+</preKeyPublic>
            <preKeyPublic preKeyId="100">BfCsHGjD09XdYpJyxc/vkz1gnwZwPd2S/cSAk0QurnNN</preKeyPublic>
            <preKeyPublic preKeyId="15">BSRBdpbnXJB9WdApemI4HI3ul3dyaeCiFlxyHRygctVA</preKeyPublic>
            <preKeyPublic preKeyId="29">Bfc76xzZ2n86Shm6BaUo7pFQnSSc8y1X4oZg+pG6J2sY</preKeyPublic>
            <preKeyPublic preKeyId="52">BchJlVzcjELfkMYbNNNg7i1MX3ppFAZMAxgkILFPfFt5</preKeyPublic>
            <preKeyPublic preKeyId="85">BawnMh3ie//q08LJIn4kCa4txz64XnrZKowrDT/JQ705</preKeyPublic>
            <preKeyPublic preKeyId="56">BZEho4bj2RxwYd3YSAfIZrCymgrNBgieKBIjF31NC8dM</preKeyPublic>
            <preKeyPublic preKeyId="97">BcEtTra9/VP44/08kcA6aqqJWdnBViMNgL/xQabWK010</preKeyPublic>
            <preKeyPublic preKeyId="89">BUmf1GkvJxZEUVVno+BqSRL85F/+yg23cjk+Z4xeH1Yu</preKeyPublic>
            <preKeyPublic preKeyId="22">BRekEYs6t7Lem2/2+j687D8O/+v7Qyq4fQ5VxEAtCtpJ</preKeyPublic>
            <preKeyPublic preKeyId="18">BSy87LJFK9cqF0dlUOHf403pIRW8DrWWzNE7QW0wMQZv</preKeyPublic>
            <preKeyPublic preKeyId="53">BT6P5TlbpS5y6mFcf3WBSjuFjtgim7jOoe7PKM9V8B5B</preKeyPublic>
            <preKeyPublic preKeyId="62">Bd8/5zqPtbWJ/Ilkr95MHf5119VAqib8zCsBKLa3ApwC</preKeyPublic>
            <preKeyPublic preKeyId="36">BTzBT0zpohuvsWQRSoJhkpwV6LflGrtBycMcTTUVFJhW</preKeyPublic>
            <preKeyPublic preKeyId="57">BbZtjFH86FM8VSQ+pHhDClmMurKajZvLvfRsIM/4h2Bw</preKeyPublic>
            <preKeyPublic preKeyId="69">BerLeJonLrTJIFRCvksuoJ0a+AlRnhoRr18adbwGHFkB</preKeyPublic>
            <preKeyPublic preKeyId="91">BZ67PFCHXGtXOBJhk+lOfRyuXjES5VLaj2FK5tegpKRb</preKeyPublic>
            <preKeyPublic preKeyId="41">BahE5MLGkzOpsjcpdAmO+Dh56B2cQ3p5TD2Rwsxpq4Zu</preKeyPublic>
            <preKeyPublic preKeyId="93">BSEK3/fLgKGJFPRjV8KUREYgfMkICOjNgTxgKZLwvX0v</preKeyPublic>
            <preKeyPublic preKeyId="20">Bd7rg84qFNn+5hEFP5/koBZNp17Im29Dfi5/jwhBMzwA</preKeyPublic>
            <preKeyPublic preKeyId="49">BTgU7LKPaNX4IqrXK9rcqtFwABeZAV23cu5pGl2lqswX</preKeyPublic>
            <preKeyPublic preKeyId="38">BUXT1/8F8mCRZ8cyq0zPk2O8tDwoGpC7+rc0W4YPxZ1k</preKeyPublic>
            <preKeyPublic preKeyId="74">BbJaQEAXeZdcwswZunsgCfYOxdf6x9UcCxKoD1p4wydT</preKeyPublic>
            <preKeyPublic preKeyId="42">BUwfZpUjB0eLfQ64+y+PedwJkL2I4dNWk2V5db2+CZl2</preKeyPublic>
            <preKeyPublic preKeyId="47">BZ+f7iKAS+4rBeJp2fM/KLVYm+H2CLPRcRGno9LAivZ2</preKeyPublic>
            <preKeyPublic preKeyId="59">BWZBuyCD15Rju/edPcWJWEygkLb12mlFL9n2NrO7mMRq</preKeyPublic>
            <preKeyPublic preKeyId="39">Bdc6BrWhmk34dxXF2v+2ekePxX6/AlcYyBq4qUNsJQYA</preKeyPublic>
            <preKeyPublic preKeyId="34">BdlTotdWpTektj86mVwEXG6JVQ4D7ZhKHSEuiKfDDbxX</preKeyPublic>
            <preKeyPublic preKeyId="46">BaGsnlr+IYxxfEmRF+BlW+2K8nD08PPfINTsr12ObItX</preKeyPublic>
            <preKeyPublic preKeyId="67">BXGdBaakCYbaCpCD6dHhqRC6wioaXxPpKV9ioOnhAaVN</preKeyPublic>
            <preKeyPublic preKeyId="95">Bfv1h3m+ytFxTw4YhqBrIKHkUdLUw7YeIsoHEd1YGGFg</preKeyPublic>
            <preKeyPublic preKeyId="81">Bdp82Fbaz2437FJt71hthxWSCWMBIw/8VnRufjYc8Q53</preKeyPublic>
            <preKeyPublic preKeyId="96">BX1zZ1cHGi1OQb+eGjliSxZmbPQ5E6ZglBs8pc4oV6Y4</preKeyPublic>
            <preKeyPublic preKeyId="7">BQiIT+E/28/rO11Ybxr+NQ8rmSVa9GYWGXpCdP8vHbEV</preKeyPublic>
            <preKeyPublic preKeyId="43">BXZeTX/osvhnESiAcy7R7/Q3Q6ELEgE9Nmtm0l3VwUE8</preKeyPublic>
            <preKeyPublic preKeyId="16">BTmr2dRoHuuNCyfXA72+W3ypDpZwSr2zTaqyJfMamCZD</preKeyPublic>
            <preKeyPublic preKeyId="51">BRqGezS5f/Z7DUU5iDWM3ibtZNRLfY/i31BPl4oQRVMZ</preKeyPublic>
            <preKeyPublic preKeyId="64">BV+jWFzmBa8DDYsZe4RC/tZ4VxZC6/sID1AeExow+MRm</preKeyPublic>
            <preKeyPublic preKeyId="31">BfNyXR8CfkLYJ8zox1+nxE5Pato6jzqXENBrMG0l9w4R</preKeyPublic>
            <preKeyPublic preKeyId="26">BZ1iht/gCzd6AAf3vqdtTjNw/kBUytcU1glfaM+Ix59j</preKeyPublic>
            <preKeyPublic preKeyId="61">BdCa0lBFNvdcSIYEae67wN8+pCE8invYBp0NX9sgaoB2</preKeyPublic>
            <preKeyPublic preKeyId="66">BQ/C5XLGhgC91fA6fOGdT5QSKNtUfsvag6dTkk16hQAW</preKeyPublic>
            <preKeyPublic preKeyId="73">BR2SNNob68yM8/gX8aewG4cMlOWeZvQS7YVcB4t9irkB</preKeyPublic>
            <preKeyPublic preKeyId="8">BUDy6UH9Ax9Wb0Hq2EQAJpo8Vm2X4i0MR5qWuP5xwShR</preKeyPublic>
            <preKeyPublic preKeyId="79">BRm00b60h2APaYeK/tw5+9RFsPT/jnbZ59F9NAuXpW5j</preKeyPublic>
            <preKeyPublic preKeyId="65">BeEni84T85BElZRa1nPrQ7FYBZpLPCZLgtwQhP3r0VZP</preKeyPublic>
            <preKeyPublic preKeyId="40">BRc9cWnxXHZbJ1sRfDMa/zePC2NT0jzPCYpZovL3XP45</preKeyPublic>
            <preKeyPublic preKeyId="24">BdGt9xlKNgHzxNDOL5Y4nFnAoPr621HuZ2MTZp+NdZoG</preKeyPublic>
            <preKeyPublic preKeyId="83">BS0jUl1QQhzXOoJn56uFMGL0qYTT5Oh60g0vs/oSAvca</preKeyPublic>
            <preKeyPublic preKeyId="82">BfPH6haNAvjeWOHJocog8Xx+i5VEu1LJrij/xD13yA5c</preKeyPublic>
            <preKeyPublic preKeyId="13">BeL6YbmwyiAs0lv06dB0hG29+k4Ittmhb4OOi7TeU9Rb</preKeyPublic>
            <preKeyPublic preKeyId="72">BctSvnzXSXF4VZOXwrW9bB6Q5J0/u4vN7YWtoMAQi9JI</preKeyPublic>
            <preKeyPublic preKeyId="70">BZ2tmu4UWTmfYi7x0DjQpYRVmkEwholwocw1YsA+Cqls</preKeyPublic>
            <preKeyPublic preKeyId="19">Be7C8m65ek9RdCyhH9Hg6kfTfL2BbH0bEVo2NfNh9lx1</preKeyPublic>
            <preKeyPublic preKeyId="88">BYEV4b/WIcGy7oguoN0C4aEJlisplIx6FJ35X3ncDi9V</preKeyPublic>
            <preKeyPublic preKeyId="60">BXfGJqB/mp+ZI9faJkfeTtG+3ybFxEZaDUUuEZVYX/Yd</preKeyPublic>
            <preKeyPublic preKeyId="86">BaKqoLh2zXb+AfqW7jfA/1uHIN1UEnaGKXb6oBLjPQln</preKeyPublic>
            <preKeyPublic preKeyId="1">BWPfL0mpnQUAx2Jnpb9r97iAB/UPAv4bucY2FMCFqtFl</preKeyPublic>
            <preKeyPublic preKeyId="80">BfcOuP4ocKKFMuC+sAxFob/+qrBZngTWs1NWyYW2Sc04</preKeyPublic>
            <preKeyPublic preKeyId="10">BZrYSLsCceCc6zNCWfQWF2EvcQSa0Bp2xqxXuf3ikfAZ</preKeyPublic>
            <preKeyPublic preKeyId="75">BWZz/7gasx/yXDII7OUdW113I6DFeFvqf7my0mdyG4ko</preKeyPublic>
            <preKeyPublic preKeyId="55">Bfsy1DLHCZZhQ8/i5vXhFG4ILEq2NdsQWNYJmWSgFWJ5</preKeyPublic>
            <preKeyPublic preKeyId="48">BQhMMpzVL9I/gXDTpe+roEHA+24CS5sxOx7Iua44QwQj</preKeyPublic>
            <preKeyPublic preKeyId="33">Benj4YHC+4d9TTaseqIxNQkh1erwVt25h9L5uyrQ7Gl1</preKeyPublic>
            <preKeyPublic preKeyId="54">BVMO38GN4AJw/Wtnmg6Up0N9g8JKFLqiLJ9sNCILDhMi</preKeyPublic>
            <preKeyPublic preKeyId="94">BWjnEmFwVbW7xPySZ2f+E1WC6cF02+UvoqpsP1MBbjoK</preKeyPublic>
            <preKeyPublic preKeyId="4">BS4dVwGvtNyAezc3AhdE9SLAkj72iJXDcJlNqYqdVq4G</preKeyPublic>
            <preKeyPublic preKeyId="92">BciGwpIU/PxH5xjsgIzRmUf3r33t3yOfG6wtbbZJ1cUI</preKeyPublic>
          </prekeys>
        </bundle>
      </item>
    </items>
  </pubsub>
</iq>
chrisballinger commented 7 years ago

@afriedmanGlacier I think you'll like bfcdb74

ghost commented 7 years ago

@chrisballinger, please push the fix to master and release it. It would be good to wait less time. Conversations can't send a OMEMO message to ChatSecure.

chrisballinger commented 7 years ago

@participante0 I'll probably cherry-pick bfcdb74 and 09b2a9247b2688c78e88217a594e6e485229eb29 into master and push a build tomorrow.

afriedmanGlacier commented 7 years ago

@chrisballinger awesome, I'll look at it today, thanks!!!

afriedmanGlacier commented 7 years ago

@chrisballinger Ummmmm, I can't seem to get this to work.

Using our eJabber 16.09 server, I ran this through the xcode debugger and it is definitely doing a much better job exchanging keys and not failing in the same place, but now it is failing on the client receiving end here:

OMEMOModule.didReceiveMessage -> OTROMEMOSignalCoordinator.processKeyData -> OTRAccountSignalEncryptionManager.decryptFromAddress -> SignalSessionCipher.decryptCiphertext returns nil -> session_cipher.c session_cipher_decrypt_pre_key_signal_message, result = -1005, session_cipher.c session_cipher_decrypt_from_record_and_signal_message, result = -1005, (cannot find a valid session)

Just in case something funky was happening on the server, I initialized accounts on talker.to (Prosody) and had the same result. After quite a few tests, at least I am always seeing the same result. Keys are successfully exchanged, and message received but not processed.

Are you not having this issue?

In case it is relevant, here's what I did. I started from scratch with a git clone on master and then did git checkout on the commit you referenced (bfcdb74b61aa9f60bc62146b8db13459969e7a76). I figured out that I also needed to install Carthage and do a carthage update. Is it possible that something isn't playing well from doing the build from scratch from Master and then checking out the commit?

chrisballinger commented 7 years ago

What you're seeing isn't necessarily a problem if the message was encrypted to another key. OMEMO messages can contain many parallel sessions (one for each device, or even more in a group chat). Can the session be initiated from one of the sides? I'm guessing you're seeing messages sent to a stale key?

On Mon, Apr 17, 2017 at 7:15 AM, afriedmanGlacier notifications@github.com wrote:

@chrisballinger https://github.com/chrisballinger Ummmmm, I can't seem to get this to work.

Using our eJabber 16.09 server, I ran this through the xcode debugger and it is definitely doing a much better job exchanging keys and not failing in the same place, but now it is failing on the client receiving end here:

OMEMOModule.didReceiveMessage -> OTROMEMOSignalCoordinator.processKeyData -> OTRAccountSignalEncryptionManager.decryptFromAddress -> SignalSessionCipher.decryptCiphertext returns nil -> session_cipher.c session_cipher_decrypt_pre_key_signal_message, result = -1005, session_cipher.c session_cipher_decrypt_from_record_and_signal_message, result = -1005, (cannot find a valid session)

Just in case something funky was happening on the server, I initialized accounts on talker.to (Prosody) and had the same result.

Are you not having this issue?

In case it is relevant, here's what I did. I started from scratch with a git clone on master and then did git checkout on the commit you referenced ( bfcdb74 https://github.com/ChatSecure/ChatSecure-iOS/commit/bfcdb74b61aa9f60bc62146b8db13459969e7a76). I figured out that I also needed to install Carthage and do a carthage update. Is it possible that something isn't playing well from doing the build from scratch from Master and then checking out the commit?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ChatSecure/ChatSecure-iOS/issues/725#issuecomment-294493423, or mute the thread https://github.com/notifications/unsubscribe-auth/AAfqH_la2ofkdqDwnSDm8_pp-4zFKDrpks5rw3QFgaJpZM4Mo5xq .

afriedmanGlacier commented 7 years ago

In many tests today, I haven't successfully received one OMEMO message. Would that happen repetitively like that? I created new users multiple times just to try to rule out various possible issues. I am using the same two iOS 7 devices for each test. I've tried initiating from both sides multiple times

afriedmanGlacier commented 7 years ago

Oh, and as far as stale keys, each time I have looked at the Profiles for each user/device (not every test, but several times), they have shown one OMEMO key for themselves and one for the other user. And the keys appear to match. When you refer to "messages sent to a stale key," a stale key would show up in the profile, right?

chrisballinger commented 7 years ago

iOS 7???

On Mon, Apr 17, 2017 at 10:51 AM, afriedmanGlacier <notifications@github.com

wrote:

Oh, and as far as stale keys, each time I have looked at the Profiles for each user/device, they have shown one OMEMO key for themselves and one for the other user. And the keys appear to match. When you refer to "messages sent to a stale key," a stale key would show up in the profile, right?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ChatSecure/ChatSecure-iOS/issues/725#issuecomment-294541160, or mute the thread https://github.com/notifications/unsubscribe-auth/AAfqH9OTqa3afiuAlLFG_d8N7e62v9Tuks5rw6a_gaJpZM4Mo5xq .

afriedmanGlacier commented 7 years ago

Lol, sorry! iPhone 7, iOS 10.3.1

afriedmanGlacier commented 7 years ago

I'm just starting to understand the OMEMO spec, so bear with me. It looks like both sides are publishing their bundles with an IQ set, but it looks like the devicelist is getting screwed up. Instead of devices adding themselves to an existing list, they appear to be overwriting the list. Or maybe not receiving the list and just sending a new one with only themselves in it. Here are some log messages from ejabber from logging in two new users (a60 and a61) about 20 seconds apart: (I had to add some spaces for these to show up)

< iq type=\"get\" to=\"a60@172.16.24.24\" id=\"108C5A90-E793-45E1-B35B-767AD21917BB\">< pubsub xmlns=\"http://jabber.org/protocol/pubsub\">< items node=\"eu.siacs.conversations.axolotl.devicelist\"/>< /pubsub>< /iq>

< iq from='a60@172.16.24.24' to='a60@172.16.24.24/chatsecure84636' id='108C5A90-E793-45E1-B35B-767AD21917BB' type='error' >< error code='404' type='cancel' >< item-not-found xmlns='urn:ietf:params:xml:ns:xmpp-stanzas' />< text xmlns='urn:ietf:params:xml:ns:xmpp-stanzas' >Node not found< /text>< /error>< pubsub xmlns='http://jabber.org/protocol/pubsub'>< items node='eu.siacs.conversations.axolotl.devicelist' />< /pubsub>< /iq>

< iq type=\"set\" id=\"1916183E-4263-4398-A8AB-D948CB68C5D2\">< pubsub xmlns=\"http://jabber.org/protocol/pubsub\">< publish node=\"eu.siacs.conversations.axolotl.devicelist\">< item>< list xmlns=\"eu.siacs.conversations.axolotl\">< device id=\"465295379\"/>< /list>< /item>< /publish>< /pubsub>< /iq>

< iq from='a60@172.16.24.24' to='a60@172.16.24.24/chatsecure84636' id='1916183E-4263-4398-A8AB-D948CB68C5D2' type='result'>< pubsub xmlns='http://jabber.org/protocol/pubsub'>< publish node='eu.siacs.conversations.axolotl.devicelist'>< item id='5D47042396479'/>< /publish>< /pubsub>< /iq>

< iq type=\"get\" to=\"a61@172.16.24.24\" id=\"DD258606-9212-4DC0-94DF-372293F17A46\">< pubsub xmlns=\"http://jabber.org/protocol/pubsub\">< items node=\"eu.siacs.conversations.axolotl.devicelist\"/>< /pubsub>< /iq>

< iq from='a61@172.16.24.24' to='a61@172.16.24.24/chatsecure60433' id='DD258606-9212-4DC0-94DF-372293F17A46' type='error'>< error code='404' type='cancel'> < item-not-found xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/> < text xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'>Node not found< /text>< /error>< pubsub xmlns='http://jabber.org/protocol/pubsub'>< items node='eu.siacs.conversations.axolotl.devicelist'/>< /pubsub>< /iq>

< iq type=\"set\" id=\"2AA2355C-49D6-49F2-A953-31AEDCB45E16\">< pubsub xmlns=\"http://jabber.org/protocol/pubsub\">< publish node=\"eu.siacs.conversations.axolotl.devicelist\"><list xmlns=\"eu.siacs.conversations.axolotl\">< device id=\"1687535012\"/>< /list>< /item>< /publish>< /pubsub>< /iq>

< iq from='a61@172.16.24.24' to='a61@172.16.24.24/chatsecure60433' id='F1AD7CD4-0835-4EEE-A7F7-83D3B59444F2' type='result'>< pubsub xmlns='http://jabber.org/protocol/pubsub'>< items node='eu.siacs.conversations.axolotl.devicelist'>< item id='5D47043D42535'>< device id='1687535012' />< /list>< /item>< /items>< /pubsub>< /iq>

afriedmanGlacier commented 7 years ago

Back to my comment yesterday about where its failing on the client after receiving the message:

In SignalProtocolC -> session_cipher.c, session_cipher_decrypt_from_state_and_signal_message, it doesn't say that the session is uninitialized, but gives "Error attempting to verify message mac" and "Bad MAC" in signal_message_verify_mac, so it never ends up decrypting the message. I had been thinking there was no session at all and was wondering why it didn't seem to try to create one.

It's probably my ignorance, but I'm confused why it even thinks it has a session. I can see it create a session when I send a message, but if I first receive a message on a device without having sent, I don't see where a session is being created (just tracing through ChatSecure in the debugger). But either way, whether I send first or receive first or log out and log in, I still can't receive. And it always gets to the "Bad MAC"

chrisballinger commented 7 years ago

Oh there may be an issue with the devicelist, but I think that is separate from the bundle corruption. I think I might report the bundle problem upstream to libsignal-protocol-c because I really can't figure out why it works nondeterministically.

A session is started when receiving the first SignalPreKeyMessage, which is constructed by the other side by parsing your published bundle (which also starts a session on the sender side).

afriedmanGlacier commented 7 years ago

I wonder the issue I see is related to the change made here: https://github.com/WhisperSystems/libsignal-protocol-c/issues/52

I'm guessing at this point this thread is the wrong forum for what I'm seeing. I'll wait and see if they respond in the libsignal-protocol-c thread. Thanks for the idea, I wouldn't have thought to look there!

chrisballinger commented 7 years ago

Not fixed yet...

therob84 commented 7 years ago

I don't know if the following could be connected to this or if it could be a completely new/different issue:

A friend switched with jabber.de from Monal (unencrypted/OTR) to ChatSecure 4.0.7. After logging in for the first time with her jabber.de-account she successful sent her first OMEMO message to me (jabber.de / Conversations). BUT my OMEMO answer to her only resulted in an alternative-message at her ChatSecure, telling

I sent you an OMEMO message but your client doesn't seem to support that. Find more information on ..conversations.im/omemo

which obviously comes from Conversations. Conversations do show a OMEMO key for this contact (should we compare fingerprints? Where she can find her own key and mine in ChatSecure? [I do not have access to a ChatSecure device])

Question: At which place this could be go wrong? Did Conversations picked a wrong key or did ChatSecure not recognized this as OMEMO message? Did they not handled the key-exchange well? What I can do to re-try an omemo-chat between us? Any advice?

Edit 1: @inputmice suggested that it could be a bug in ChatSecure. But besides this an important point could be to switch Monal meanwhile to OFFLINE to avoid interferences. I will check, if this solves the problem for the moment and report back here.

Edit 2: I could solve this problem by disabling/deleting Monal, which avoids interferrences between ChatSecure and Monal using the same accound with OMEMO at one device..Now it works (also with <=CS 4.0.7)!

afriedmanGlacier commented 7 years ago

OMEMO worked immediately for me in 4.0.8. Possibly fixed now?

varun-user commented 1 year ago

Hi Team , 

         I'm facing this issue , 

         'org.whispersystems.libsignal.InvalidKeyException: Invalid signature on device key!'

         i tried it from conversation code

Non working Bundle

BWAgkeGro0tPZDgaHQvXm8F9t8/UHLtAoMs0GHfUxGRi6qR5aID1TPmGlXWz/+4pHzM9oQbFnD4vq1ByDp+fHkvbBObxqZj81QmrlXWQYd9j4SMnHeZFs2jOMZA3OuAgDg==BWD+ywkt4w8KJMOvRgJmZ7GBlYN16eToDi17Sj/p76VfBartGMI13r8RM9XexA1VGvGm9eOMuDW3lpbtCp1HVY42BW9VU4TppyTQdzzPR9SHxkSl62uaUxLCjCP40XKDcs5IBUVdkUWILS6bcvr8xaUDCRBzKV6Y39c47oSWdhPK0scaBTGuxFyFbgBXe4S8SvlQmUuhJo3aGtbf2hcklML0rGJpBQydabc5xVaf7CE1mr3txTJTW9RjpOkYrzg86sSuwSNXBf1i278bZ4OzsYoINSln0QUKmFGY+Sx4PoAlLY48Dp4XBRIQFSmi+GaihbQ6JZ+EcyPEcIsN/YEB0WuJIu8dLHl8BduW4IFYARof+L1fBfm1wzH81heOgWZvtxw54nXCPkgsBTOlAUgVVB1xk+O9r7FTj87yNiejKwWOAWbRPvPuCI1PBfBSa3epg7lsoCLNmD85J8KeBXigqXi1y42qnlh4Q507BQSHKR1jtN2pTBsrB4CxEevYOqkH+1LKKT8gM6VK3Z4MBZH7QRNENKa63D7M5kZs9VSPGCRhzeq2Fk4Vv19ZeCh+BScabOoJ9DXkpR5BprWqKo7NEeUaqFm3pGE+El2/UEBXBU5G7Ntmc3zltgDWd6UUUQ5rKcyrtfbZ1q3z27+azP4kBYrGx4ZqXZ9Jf5TryDVd4ldBxHHISXXXU3wJOWOYQo8ABRiI2xEUUDppfxAoGzRXa2sRDtcYd3x4J5jHih/NdZBeBcmj4W6TuaE96hD4XMy5cGHqY8OaNEjdH5N1rJOONa5wBXVJbq+blqsesb2iKVKBusBJ867JVhA1kFYI8mMTevsQBXLXc/EsG3RVj7IxLGMW8bYjoQEtumkUzov6rYHuj7IEBUXshVNXgoj3/6tq8WabbLuItjyjsxwV+TtHxhrXg3lRBeGNFdQ6ote6AodCdRq2nqzMVwxGNF8Kv0bQmINkjSRoBb4vIVL4jzg2BRczlTgJWX51u3q0ld+G5a8lVEzjYUVzBSWmsW5SanN8qtnFZxw0XUPIOBIoM8Rrv9awk4sZN0MJBYDw2tSexMMi+k4AXwpnXq1uywf3ypxbXo2IZOiBSAUFBbA3SEqVoN1Ak2hX1+SOiV6sS0C2RZsWsQ8XM7n5/aFOBTtzXfyewFpC4rATbvrL+lPcnL9NFc60GWrqOKHFwjIOBWpdsTrXCyogN8hOnnGOFVtnin6nayltrKG1k0iXo/cFBWwGSLSovyD9VVyBpze6MLCFZV1F7G5LQhdOvZJDG1MvBaKJsk9BbYMbds24z3V+4hUUHFHNLPkgQ31injwoRcx0BejbD3Nec6IZhjUqJPlR3tVaVpPhon9xmtVNEulaZA4tBVbXi2L6aTIRBKtEJ0Wrj86ZPR7ZxO3RRx6Lyz8LPiYbBVt4urANBi5xhjK2gP4uUOlg9KZefRDdIE04xGUVnBReBSScjIEcm70YtUdjKynDUnx2/ygxiOgkdr9C1gnrE4QZBRw9hdAudEuzRFUYr5924IS5hDK9Y6pVOzgmoThJjH4dBWpvr629i1xNVfoqd9YL5GAtUvMPijeuS2K2fXyzk5opBYmzR4FGk7nP4ZVGGWlAbRaQuG9C+DJYpLHewwZGNKByBf3eax3GOpfUKU0wT1d701okxeuu2bcCQrNBM5iiayxoBTX6QOfQM8ayLYoXsVLT2elBqPv03FeYNi4PUGs/SxEPBUkfAvOkAn19d5C+ZvPjmWrd0RmnfJgiADabJ2CMvTIbBcMd6mz95qx5jZ2hZ5lyNdfIe2PSAkmbi9W1uknqtEpkBWQnfKE6i9LCkstizUapDVU+MYZWBcFWmDOJwGyhChh9BVC3KlL/4o4KamUnkCoudQs8m/LjK3qjgbaAF/1LdLM9BRaa8kHP/K+CWwhdCZ23gBgw1CSNHS/4ykJWZD65w6NQBYQCi4VYbccwPkBChHQ7Cc8lYTPgc/eae+Pcv+9GJoE/BQrDlORJBCFU7LcEpWp1N041MdM/60/xpPWQdlSjJB96BTV6+XjLvU1CmxxAliJzPcrNuiiCnLX4MmUmOUk72rhOBVaaLJgnk2FMZAo5UBIeyeR1I0Et3b3nfj1I71g5hlQyBeGWgSsQlJPX5qF1ubZfV1Ug+421E76SmjARtAeoIK03BbR9kuqoK+ELPP3FatJH52foPntTBAJZboOYiwobukk6BTJdPesoZd4DSWp+aNgxGT/IQMciLgsNb+zCJcRd6UBZBeB+Ia3yG6tBUnHdnRLlbJusayatWFjCuGi91gKqOFcBBZV/1K1xSBBFjqOpk3jgkhrcgZZ7TrlB0Jd+PQy1iigdBYeTvEKP8bc35Zp3N3ZltQ+hlqE6yhOfG5Q89ZRLTJYYBT8pwAGHpUdQExvhnNU7m3ofIxjn0cmmz55ScV1jyypmBRF3AmKKbdgfB/g4Jx0OqJodXPA6sOkp7UKl7RLupohDBbORCuN6DfC/N8+GsOGoEMEY/oj85aQ1HyQmsz+/hgRqBW0XKC7/9k14JhEjW4AC4aRH55egJdXEXzkcEFnR64xBBaHk9CZF8lJ3qZjTlvIvMcPjlKD8gbEmj3e4FE36A585BUPeD/7nGaq5TGDHQvHPTRJdr6CXeIZf9gXqUAzqxAlaBaZ8K8b3CHdSjJh0hup4dMeTqzKIeAFNqnf169ADlZIJBe/TOMvMW2Qxecd8wICMrvC4nSLAtYuNS+H8e7OTPbkcBUw348HXuCYS4rIfL4+oLlNt3h7rcL8zwvJFkWa0tRoyBYYXWnoVGcI19t/yficzOmweQRQ2YJ0zQ3xqUCK6YX0HBTv70xEt8MCHO5u47I0GWJgwoPt12Fzo06HFdrvtG/BWBb9sWvKb3hmSCudjwYgQmSXC0L+OPnSTN3Ta8ZT2BLRFBSVfTqUBIGhqPi6oOdplZjictP63Zz4Q5jXTTGrZ+AIBBWCn9VMZs5mLUnxRcCurHnSPPJddDtg3gxQ10U8fmDcBBffCV279s1LzRj/eQi7JfrP/BuSFbXOsaFpLl1wB+EI7BWuxIGQsYzzc7t5gUMlalCWvHeGhczlHMcCpp8LvswByBYzA7kDS+sYmH6hJTZSZCRyXHv8mBNExFHmRr6oZcAACBTG9lSmZJxgU8t6p/8k8Wl06CyHKPZC52srXu4fI9bVwBSzTLU6b0pzDRDA1PAHx/9ZmwA6ILTGSgX6Ej7bt5Rs/Bbo3MwRY11P7VdVi6/fLgN6bE32LWY+JsL1fyFJuvCkEBXUhuJ3eDQ9Q2lVcMC0mjoA5PLPobTLTXQOWvO8iD99ABcWgfR0O851al5S0t5mDEjWtYWp5qP8TP2evO6oLRGc/BSFAmsq5MwilSsutgqenzceaAEhkoyH5gaVyfI4zZQkMBfquRpjyrMYrG/61Y7+NUdAsBm/TI+me4S4OBW7CSOYNBXbQBRqsoL9m0I7pvlPWdvFCK9UnSjC7Ir8inn+jqxFMBYxRkwEVYszDcGy+A128kgXUFsYD+zpIUIg3wH3eGBw3BSErQCgwx0LqsZyEhTUN3zIp3qj4cPwz0S7nzZhWz5AmBeccg6sxL+Kax6q42flog1GO3qmvFkRnkanWQ+yKipZhBeZQSbvgJYrxv5GfCV68Q7PJJWUm31CvIg9y/+Sqj9QRBQLK+cRHysG3aijVHVJunedgf3Xhnmw8EeyBM+rngcBqBY6dC5DQ47codRQhicf4hhbOEa7E4mvw3+nZ4xQPjVdMBW/nZMNLl57L2t37OtHBEgRoDYsonGXCZD5A2logrSs8BZAvx7DONSSSdeOaRhdYcyeO0i2TiqZwx074z7SChYlVBXmNB1//KWhs007p/0hZzXWwnrjmXkT5v7z9vLGayjk6BQ8CTxdj/SqOnUDhcK2WqUwHCIoYmMOSdxelhM1JYQkSBQMbJ02WBJ8A+zidil0O3bd3EPvTxihvkNTx8uqp+idPBYskOwgzm7vbDpZ73vqMIeVBQ6vl8/RmaOIOTorPP5UTBXlry8TLRAoniqL5uhwXWgKBe/EzVs8OBluVN2xM0EkYBakdG/RrgaHjL+ZI8KxtBgf/VwCT4NRmMtIlVmJLgfh2BWsr2ERSp3G/k4gM5vdAIhyDffZ95Wr3P61onctYRLMuBfx6KE3l6FRRH7vRui94ew4Z/Ag5FQ2sOzyjBq/ApkEXBfR3T2C8AOYDKUKQD+pGiSQUqRU4vhGe7APdg9tw+7kHBRSdNfItMQfDDKpolMhbI5ogTiMM/3HTw9p46wtOGOYwBYCCrmHev2PLHEU3DB6MKrkNBu+Chlm99OBWt7SZRFE/BemDJeN8WALFT+gRzoRkwv+Au6wroQmRHFfjBV7nAnd1Bf7SWvuGHo0MeY6EuEei96XdVRXRiT2krM2urBCm8Co0BTUUz4V/xP7owHDs7THwEHgoQIn3UaOdeM4UQTtl0pUm

when trying to process this bundle :-

final PreKeyBundle preKeyBundle = new PreKeyBundle(0, address.getDeviceId(), preKey.getPreKeyId(), preKey.getPreKey(), bundle.getSignedPreKeyId(), bundle.getSignedPreKey(), bundle.getSignedPreKeySignature(), bundle.getIdentityKey());

            try {
                SessionBuilder builder = new SessionBuilder(axolotlStore, address);
                builder.process(preKeyBundle);}

Internally this method gives me an error

public void process(PreKeyBundle preKey) throws InvalidKeyException, UntrustedIdentityException { synchronized (SessionCipher.SESSION_LOCK) { if (!identityKeyStore.isTrustedIdentity(remoteAddress, preKey.getIdentityKey(), IdentityKeyStore.Direction.SENDING)) { throw new UntrustedIdentityException(remoteAddress.getName(), preKey.getIdentityKey()); }

// this exception I'm getting

  if (preKey.getSignedPreKey() != null &&
      !Curve.verifySignature(preKey.getIdentityKey().getPublicKey(),
                             preKey.getSignedPreKey().serialize(),
                             preKey.getSignedPreKeySignature()))
  {
    throw new InvalidKeyException("Invalid signature on device key!");
  }

what can be reason for it ?