ChatSecure / ChatSecure-iOS

ChatSecure is a free and open source encrypted chat client for iOS that supports OTR and OMEMO encryption over XMPP.
https://chatsecure.org
Other
3.13k stars 1.02k forks source link

Issues on reinviting to MUC #826

Open mimi89999 opened 7 years ago

mimi89999 commented 7 years ago

When a ChatSecure user is offline and I reinvite him to a MUC using the reinvite option in Conversations, ChatSecure after opening will show the inviter bare JID (mine) in conversations list even tho I am in the list with my nick. After clicking on my full JID in the list, ChatSecure will often crash. Sometimes it will even crash just after opening. This happens until I remove my bare JID from the conversations list. I sent multiple crash reports for that.

chrisballinger commented 7 years ago

Thanks for the report. There is a crash related to group chats in general that I'm trying to fix in the next point update.

mimi89999 commented 7 years ago

In 4.1.1?

mimi89999 commented 7 years ago

I still experience crash even for MUC invites in 4.1.1 (98)

mimi89999 commented 7 years ago

@chrisballinger Fixed in latest TestFlight [ChatSecure 4.1.1 (100)]. Thanks.

mimi89999 commented 7 years ago

That is still failing sometimes with ChatSecure believing my JID is a MUC JID and that my resources are members.

chrisballinger commented 7 years ago

Can you send a redacted screenshot and elaborate on what you're seeing / expect to see? There have been some pull requests recently that changed the MUC participant behavior, but we've only been testing in a one specific room configuration. Perhaps you can invite me to the MUC with the unexpected behavior?

mimi89999 commented 7 years ago

img_1624 img_1625

@chrisballinger Here you are. Really strange...

chrisballinger commented 7 years ago

Are you friends with the room occupants? What is the room configuration?

mimi89999 commented 7 years ago
  1. Create a MUC in Conversations and invite the ChatSecure contact

  2. Delete/remove the MUC and the conversations with that Conversations contact in ChatSecure

  3. In Conversations go to conference details, long press on that member and reinvite

  4. Come back to ChatSecure and see the issue

Does not always reproduce.

chrisballinger commented 7 years ago

There is an open pull request that might alter this behavior a bit. Please test again after I put out build 101