Notifications: Allow to disable message preview

ChatSecure / ChatSecure-iOS

ChatSecure is a free and open source encrypted chat client for iOS that supports OTR and OMEMO encryption over XMPP.

https://chatsecure.org

Other

3.13k stars 1.03k forks source link

Notifications: Allow to disable message preview #99

Open thomasst opened 11 years ago

thomasst commented 11 years ago

My phone is password protected and I don't want anyone to be able to read my messages when I leave it unattended but I still want to be notified when I have new messages.

There could be three options on what to show in the notification:

Only show me that I have new messages (or how many)
Only show me who the sender is (iMessage lets you do this)
Show both sender and message preview

I'd be most happy with the first option.

chrisballinger commented 11 years ago

Oh that's an interesting idea and should be relatively easy to implement, especially the second one. "How many" is slightly more work but also pretty easy.

mwlczk commented 6 years ago

1st option should be the default for encrypted messages/chats. A previewed message is processed via iOS and thus other apps might be able to read the content!?

chrisballinger commented 6 years ago

At least on my iPhone X running iOS 11.3, you can disable notification previews when the phone is locked via iOS Settings -> Notifications.

A previewed message is processed via iOS and thus other apps might be able to read the content!?

False

mwlczk commented 6 years ago

@chris: i mean something like this (OK it is signal and it is a Mac OS) https://motherboard.vice.com/amp/en_us/article/kzke7z/signal-disappearing-messages-are-stored-indefinitely-on-mac-hard-drives This might be similar in iOS. Whenever iOS needs to show a notification it might store/process the content. So it would be better not to show the content to iOS for message preview of encrypted messages. :relaxed:

chrisballinger commented 6 years ago

Yes, but iOS apps are sandboxed and cannot read arbitrary system files like they can on macOS. Keep your iOS system version up to date and your risk is very minimal of a sandbox escape.

I'm not opposed to the idea if someone else submits a pull request, but time and resources are tight so this feature won't happen any time soon without some outside initiative.