search

ChatSecure / SignalProtocol-ObjC

Unofficial Objective-C wrapper for libsignal-protocol-c
https://github.com/WhisperSystems/libsignal-protocol-c
GNU General Public License v3.0
12 stars 15 forks source link

Improve error handling and associated nullability annotations #2

Open chrisballinger opened 8 years ago

chrisballinger commented 8 years ago

There are a number of methods (and inits) that silently fail and return nil without having an error parameter, and in conflict with the public nullability annotations.

chrisballinger commented 8 years ago

This assert should be an NSError: https://github.com/ChatSecure/SignalProtocol-ObjC/blob/bf612f5cdee38d4716969505b64d24a62de4e0bc/Classes/SignalSessionBuilder.m#L49