Chatie / git-scripts

Git Hooks Integration for Chatie Projects
https://npmjs.com/package/@chatie/git-scripts
Apache License 2.0
1 stars 4 forks source link

Fix push hook #20

Closed binsee closed 2 years ago

binsee commented 2 years ago

Fixes #19

Need update git-scripts to new version link git-script/pr: https://github.com/zixia/git-scripts/pull/13

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

huan commented 2 years ago

Please make sure the following requirements have been met for your PR before we can continue reviewing it:

  1. You have signed the CLA by clicking the [CLA | not signed yet] button from the comments.
  2. The PR has passed all the CI tests and turns green. (you can execute all tests locally by running npm test)
binsee commented 2 years ago

Please make sure the following requirements have been met for your PR before we can continue reviewing it:

  1. You have signed the CLA by clicking the [CLA | not signed yet] button from the comments.
  2. The PR has passed all the CI tests and turns green. (you can execute all tests locally by running npm test)
  1. done
  2. The same error will be reported in the main branch
 binsee@bogon  ~/CodeWork/chatie-git-scripts   binsee/issue19  npm run test

> @chatie/git-scripts@0.6.2 test
> npm run lint && npm run test:unit

> @chatie/git-scripts@0.6.2 lint
> npm run lint:es && npm run lint:ts

> @chatie/git-scripts@0.6.2 lint:es
> eslint bin/**/*.ts src/**/*.ts tests/**/*.ts

/Users/binsee/CodeWork/chatie-git-scripts/tests/fixtures/smoke-testing.ts
  0:0  error  Parsing error: "parserOptions.project" has been set for @typescript-eslint/parser.
The file does not match your project config: tests/fixtures/smoke-testing.ts.
The file must be included in at least one of the projects provided

✖ 1 problem (1 error, 0 warnings)

// ----

 ✘ binsee@bogon  ~/CodeWork/chatie-git-scripts   binsee/issue19  git checkout main    
Switched to branch 'main'
Your branch is up to date with 'origin/main'.

// ----

 binsee@bogon  ~/CodeWork/chatie-git-scripts   main  npm run test     

> @chatie/git-scripts@0.6.2 test
> npm run lint && npm run test:unit

> @chatie/git-scripts@0.6.2 lint
> npm run lint:es && npm run lint:ts

> @chatie/git-scripts@0.6.2 lint:es
> eslint bin/**/*.ts src/**/*.ts tests/**/*.ts

/Users/binsee/CodeWork/chatie-git-scripts/tests/fixtures/smoke-testing.ts
  0:0  error  Parsing error: "parserOptions.project" has been set for @typescript-eslint/parser.
The file does not match your project config: tests/fixtures/smoke-testing.ts.
The file must be included in at least one of the projects provided

✖ 1 problem (1 error, 0 warnings)
huan commented 2 years ago

Thanks for signing the CLA!

Yes, I see that the main branch is broken too, so we need to figure the problem out or the new version can not be published via the DevOps pipeline.

I'll have a look at it after my talk tomorrow, or it would be great if you can find any clue for the problem and try to fix it.

Thank you very much!

binsee commented 2 years ago

I modified tsconfig and the test has passed, but I don't know if the adjustment is correct, because it is different from the configuration of other projects.

binsee commented 2 years ago

Now run git push continuously, no more bump versions

binsee commented 2 years ago

Waiting for https://github.com/zixia/git-scripts/pull/13 to merge, and run CI again

binsee commented 2 years ago

Please bump the minor version so that we can merge and publish it.

Thank you very much!

done

binsee commented 2 years ago

@huan After this pr was merged, no new npm package was automatically released.

huan commented 2 years ago

I have just published the new version manually. This repo has not configured the CI/CD so it has not been published automatically.

Please let me know if it works as expected, thanks for mentioning me!

binsee commented 2 years ago

@huan There is an error in the packaging process, the dist folder is missing, so it cannot be used correctly.

huan commented 2 years ago

Sorry for that, I have re-published it as 0.7.2, please try the new version.

binsee commented 2 years ago

Update:

It is a local cache problem, which has been solved


~I don't know why the README page for @chatie/git-scripts has no content.~

https://www.npmjs.com/package/@chatie/git-scripts