search

Chatie / git-scripts

Git Hooks Integration for Chatie Projects
https://npmjs.com/package/@chatie/git-scripts
Apache License 2.0
1 stars 4 forks source link

Should we allow skipping lint checks? #31

Open binsee opened 2 years ago

binsee commented 2 years ago

In some projects, lint is problematic. And it may not be repaired in a short time, then push will be block.

E.g. #29

It would be useful to have a SKIP_LINT=1 option to skip lint checks.

huan commented 2 years ago

I think we can add an option for users to skip them.

However, if we use an environment variable to skip it, then I think it should follow the name conversion of the existing ones.

For example:

  1. NO_HOOK & NO_LINT will match, or
  2. SKIP_LINK & SKIP_HOOK will match.

Please feel free to create PRs to add your improvements, and also please don't forget to add the usage to our README as docs.

Thank you very much for your contribution!