search

Chattahooligans / hooligan-hymnal-app

MIT License
12 stars 15 forks source link

Use in-app browser to open web links #137

Closed wedemmoez closed 3 years ago

wedemmoez commented 4 years ago

In 2.0.0, the app link behavior was changed to open links to external sites in the OS browser. The user then has to manually switch back to the application.

galenriley commented 4 years ago

Will do this inside config, but should name the config property with the assumption that this behavior will eventually be a user setting

galenriley commented 4 years ago

Maybe the config should have two flags, one for each platform?

wedemmoez commented 4 years ago

For now that might be a fine solution. I really like the idea of making it a user choice in the future

galenriley commented 4 years ago

Proposed implementation in #141 for v2.1.0. Please review.

galenriley commented 4 years ago

@wedemmoez , so this makes sense for links baked into the app, like in the drawer menu

Does it make sense for links in the text of news feed posts?

wedemmoez commented 4 years ago

Links in text posts can be linked to the config option? it should be a global setting

galenriley commented 4 years ago

It's currently a single global setting, just didn't know if posts in the news feed should be different

galenriley commented 3 years ago

@wedemmoez, I know link handling came up again today in conversation. Can you either make a request for me or close this issue ticket?

wedemmoez commented 3 years ago

Not urgent, but possibly a way to select which links open in an internal browser vs externally? its an extremely limited use case so I'm going to close this until it becomes a necessity.