search

Chattahooligans / hooligan-hymnal-app

MIT License
12 stars 15 forks source link

Player UI considerations #139

Open galenriley opened 4 years ago

galenriley commented 4 years ago

Current version doesn't crash any more, but it's a wonky pattern.

At minimum, need to implement a PlayerView component and SinglePlayer screen to match Song pattern

But also, the whole Roster/Player/Song or Roster/TwitterList interaction is weird and the backbutton behavior is not sensible, so let's think about the whole thing.

galenriley commented 4 years ago

but like also the whole thing needs to be revisited, what with player image galleries and so on

galenriley commented 4 years ago

oh hey also there's a buncha calls like this.props.navigation.setOptions({ header: null }); all over the place that don't cause harm to exist but do nothing (because the behavior we want is set in the navigator setup currently, and the way to do it in the screen is different) so delete all of those when addressing this ticket