search

Chatterino / chatterino-browser-ext

26 stars 16 forks source link

fixed collapse button #22

Closed mfmarlow closed 4 years ago

mfmarlow commented 4 years ago

I made the closeButton point to the close button on the new layout so when you click it it actually collapses chat.

mfmarlow commented 4 years ago

Ahh just found a slight issue with this. Check this gif: https://i.nuuls.com/MhbyD.gif

When I move the window, the chatterino extension will move to the other monitor very quickly and move back.

@alazymeme this appears to be an issue in #19

ALazyMeme commented 4 years ago

Ahh just found a slight issue with this. Check this gif: https://i.nuuls.com/MhbyD.gif

When I move the window, the chatterino extension will move to the other monitor very quickly and move back.

@alazymeme this appears to be an issue in #19

Ok cool, we should be good to merge this. I can create a new issue for the teleporting issue.

mfmarlow commented 4 years ago

On further inspection, the problem appears to come from the delay between the extension communicating the updated x position to the Chatterino application. I think the fix for this is going to be in the application rather than the extension if it's fixable at all.