search

Chatterino / chatterino-browser-ext

26 stars 17 forks source link

Update watching tab without replacing chat in browser #81

Closed 2547techno closed 1 year ago

2547techno commented 1 year ago

Currently, there is no case where tryAttach is called and the setting replaceTwitchChat is false since tryAttach is only able to be called when replaceChat is called. Removing this if condition allows that to happen.

One issue that will need to be addressed in Chatterino is the live ping sound that will fire every time the user switches streams in the browser, regardless if the "watching" tab is open in Chatterino. I suggest muting the "watching" tab completely from live ping sounds since there is no need to have them (or at least put it in a toggleable setting).

2547techno commented 1 year ago

Oops, yea you're right, I missed over the event handlers that call queryChatRect, I'll open an issue for the live ping sound thing. Thanks