Chatterino / chatterino-browser-ext

26 stars 17 forks source link

Chatterino is offset in the native browser extension #89

Closed ichiuto closed 1 year ago

ichiuto commented 1 year ago

I tried resetting the app, uninstalled then reinstalled the browser extension. Still offset. 2023-03-27 2023-03-27 (1)

Felanbird commented 1 year ago

You don't have to open a new issue everytime you want to change something, you can just edit the old one

Nerixyz commented 1 year ago

Let's track this in here.

To make reproduction easier:

I can't reproduce this with the latest Chatterino version and neither Firefox Nightly nor Google Chrome.

ichiuto commented 1 year ago

@Felanbird Sorry about that. It gave me an error the first few times I submitted and I couldn't find my post, so I thought it didn't go through. Sorry if it was accidentally spammed!

@Nerixyz

It only started this early this morning. I tried restarting everything as well to no avail.

Mudias commented 1 year ago

The same problem started happening to me as well this morning, I tried reinstalling the extension, using different browsers and different chatterino versions but the problem still happens no matter what. The current Chatterino version I'm running is 7.4.2

Oblivious322 commented 1 year ago

Same problem

Using chrome on windows 10 Tried Nightly release, normal 2.4.2 and 2.4.1 running adblock, bttv, 7tv, ffz I use bookmarks bar

Nerixyz commented 1 year ago

I reproduced it. It seems like this was introduced in #28 and only shows up if you're using a high-dpi monitor. I'll try to fix it.

Nerixyz commented 1 year ago

As you can see, I made a fix. Until this lands in the add-on stores, you can manually load the extension. This isn't persistent across browser restarts.

Firefox: You can either use a copy like on Chrome, or use a zip file of the src folder (current: chatterino-browser-ext-fix.zip). Go to about:debugging and click on This Firefox. There, click on Load Temporary Add-On.... In the dialog, either select the zip file or select src/manifest.json from your copy.

Chrome: You need to have a copy/clone of my branch locally (or the master branch once the PR is merged) e.g. by clicking on Code > Download ZIP. Go to chrome://extensions and enable developer mode. Then click on Load Unpacked and select the src folder from your local copy. This doesn't work, as mentioned by others, because Chrome generates a new ID for the unpacked extension.

ichiuto commented 1 year ago

@Nerixyz Thanks!

I'm not sure if the issue is just for me still, but when I followed the instructions to update manually it still had an offset?

2023-03-27 (2) 2023-03-27 (4)

Nerixyz commented 1 year ago

I'm not sure if the issue is just for me still, but when I followed the instructions to update manually it still had an offset?

Are you sure you disabled the regular extension? You can only run one extension at a time.

ichiuto commented 1 year ago

OK, I disabled the regular extension. Now, this shows? The app won't load?

2023-03-27 (6)

These are two errors that popped up in the extensions page:

2023-03-27 (7) 2023-03-27 (8)

megamen128 commented 1 year ago

I loaded extension from bugfix branch and have the same issue, chatterino is not detected on 4k nor 1080p monitor. Official version works well on 1080p monitor and has this offset on 4k monitor

Nerixyz commented 1 year ago

I loaded extension from bugfix branch and have the same issue, chatterino is not detected on 4k nor 1080p monitor OK, I disabled the regular extension. Now, this shows? The app won't load?

My bad, I only tried it on Firefox. Chrome generates a new ID for the unpacked extensions, and Chatterino only accepts a set ID (glknmaideaikkmemifbfkhnomoknepka, for security). For the Firefox version, the ID is contained inside the manifest.json, that's why it works there.

If anyone knows how to make Chrome use a specific ID, that would be helpful for the time being.

megamen128 commented 1 year ago

I added following property to manifest.json and it works now :) "key": "MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAjtsADaNVdZWOwRl7Sdth0tv2vq5H9t9jVaBK8FQbs6fmZpAfgt5U4LBRI6RiI6TocxOYY0KNEdNUNmC58+3UoDn94jDViaOVszMeJeIIozDtfcpje3I5DC6pgNGJdRVwK/JMbiL+jyfc3a2ztZE36ufhfpVke192vuw12TmhYyVq+5P7c5/E2Dc8CFwDZBxLwXXlnyTZIWEHGadaWoqY5Jnjjmif5I6O4WG35Kf+GAIKNqiq03nxicpXm1UiujHxG1R5YtD0CfqjutaxsQGt7H2qWksrTC7x5EqoUI1IgPKsMYXSc/yWmkdm/viEdC0LeyYM+ivaOJRn5fECWNMrCwIDAQAB",

source