Chatterino / chatterino2

Chat client for https://twitch.tv
MIT License
2.07k stars 448 forks source link

Chatterino crashes with SIGSEGV after trying to load 1000 messages from recent-messages API #2226

Closed zneix closed 4 years ago

zneix commented 4 years ago

Describe the bug I recently tried selfhosting recent-messages service and after setting message limit to a "little" higher than original instance, but I encountered crashes. Narrowed it down to big channels with 1000 messages in cache crashing Chatterino. I know that I am first person to ever selfhost mentioned service, so this is not as important and probably nobody is as silly as I am to set message limit to 1000 or higher, but this is something that chatterino should handle on it's side and prevent from SIGSEGV'ing.

To reproduce

  1. Set up recent-messages service on your own with message high limit (I encountered the issue with 1000).
  2. Make sure you have channel that has 1000 messages in cache (like #forsen).
  3. Run Chatterino with custom Environment: CHATTERINO2_RECENT_MESSAGES_URL=https://recent-messages.zneix.eu/api/v2/recent-messages/%1
  4. Get an error fish: “chatterino” terminated by signal SIGSEGV (Address boundary error).

Chatterino version Chatterino 2.2.3-beta2 (commit 05aab8684)

Operating system Arch Linux 5.9.10-arch1-1

Additional information none

Mm2PL commented 4 years ago

dupe or related to #1421 pajaM

zneix commented 4 years ago

I am honestly amazed and shocked I opened duplicated issue just after original one had it's anniversary few days ago. xd