search

Chatterino / chatterino2

Chat client for https://twitch.tv
MIT License
2.06k stars 449 forks source link

Rework loading of Chatterino badges #3118

Open Felanbird opened 3 years ago

Felanbird commented 3 years ago

Describe your issue

Chatterino badges are only loaded on startup, it might be nice to look into reworking this, as the most common issue seen with it is with new Supporters who don't see their own badge, while users who recently opened Chatterino, do.

Screenshots image

image

Screenshots from discussion while granting a user the Developer badge, logic applies to Supporter & Contributor as well.

OS and Chatterino Version N/A

LosFarmosCTL commented 3 years ago

Could take a look at it, but how exactly should this be implemented? The badges are retrieved from a normal REST api right? So should there be some kind of timer to fetch an updated badge list every n seconds? Or should it be integrated into some other reloading mechanism already present (seems like the better option to me, but the question still remains which one, maybe the emote reloading since that already reloads FFZ mod/vip badges?)

xHeaveny commented 3 years ago

Could take a look at it, but how exactly should this be implemented? The badges are retrieved from a normal REST api right? So should there be some kind of timer to fetch an updated badge list every n seconds? Or should it be integrated into some other reloading mechanism already present (seems like the better option to me, but the question still remains which one, maybe the emote reloading since that already reloads FFZ mod/vip badges?)

I guess with reloading the FFZ and BTTV Emotes this can also be reloaded so

leon-richardt commented 3 years ago

I also believe that leveraging the F5 emote reload semantic is the most sensible place to implement re-fetching the Chatterino badges for now

zneix commented 3 years ago

I guess with reloading the FFZ and BTTV Emotes this can also be reloaded so

I don't agree with this. Reloading with F5 already takes into account many items - all twitch emotes fetched from both kraken and helix. Channel emotes from all the services and if we keep adding things, like Global third party emotes / ffz / bttv (/ 7tv) badges it's gonna get very messy in my opinion.

Another point against the issue in general, Chatterino badges change rather very rarely, especially developer/contributor ones. So I'd rather consider these as something constant. As for supporter badges, you're already explicitly told on the wiki to restart your Chatterino in order to see the badge. When someone donates it's probably also rather a one-time action, so if there's no way to manually reload these badges it shouldn't be a big deal. If anything, there could be a separate option to reload only Chatterino badges (or badges in general, if we were to add a way to reload other badges, e.g. ffz ones). Why? This is not something you wanna reload/refresh so often as the emotes and I think calling Chatterino API every time you wanna refresh only emotes is unnecessary.

leon-richardt commented 3 years ago

If anything, there could be a separate option to reload only Chatterino badges (or badges in general, if we were to add a way to reload other badges, e.g. ffz ones).

I strongly disagree with this. Chatterino should strive for a simpler UI instead of complicating things by introducing many different shortcuts for very similar things (from the user's perspective, at least).

Also, if the API request frequency is of concern, we could always ratelimit client-side.

LosFarmosCTL commented 3 years ago

Chatterino should strive for a simpler UI instead of complicating things by introducing many different shortcuts for very similar things (from the user's perspective, at least).

Especially for something like this I don't think that an extra button makes any sense. If a user is already dedicated enough to manually reload supporter badges via some sub-menu button, he might as well just restart chatterino. The problem, at least from my perspective, is not so much how difficult it is to reload the badges, but that it is a dedicated step someone has to consciously take.