Open Felanbird opened 2 years ago
Moving this comment from the earlier discussion
Possible fix: Modify the 'large' option for link previews to be bigger or alternatively make an extra large option. I have shown below how big I thing it should be.
Edit: With some help from Karar I learned that you can put in pixels how large you want the preview, however it's way too blurry to be useful. What I was more so referring to was to make the preview bigger while keeping the same image quality. As a side note, I do like that there can be custom values for this and not just the default presets, however as previously stated, anything larger than the 'Large' preset isn't really usable.
I looked into this a bit. The thumbnail that comes back from braize.pajlada.com is already very low res, at least for GitHub thumbnails. Compare https://braize.pajlada.com/chatterino/thumbnail/https%3A%2F%2Fopengraph.githubassets.com%2F562629478fb54c347751dbfe92f9da6a7ecb659f5121ad1e2b2c829ddca533fc%2Frecp%2Fcglm and https://opengraph.githubassets.com/562629478fb54c347751dbfe92f9da6a7ecb659f5121ad1e2b2c829ddca533fc/recp/cglm, for example. I don't know how the braize API works, but we would need to pass a width/height or just get a higher res image by default.
The braize API is this: https://github.com/chatterino/api. The maximum thumbnail size by default is 300 and I believe that instance uses the default config.
I see. Is there anything that could be done here then? I don't know if altering the thumbnail max size is feasible.
@pajlada What would be your opinion on upping the thumbnail size for the official Chatterino API instance?
We could also have an option to fetch the thumbnail directly from the client and not proxied through the API (needs to be an explicit opt-in due to the privacy risk), but I don't think it is the best thing to do.
Discussed in https://github.com/Chatterino/chatterino2/discussions/3462