Dock Icon revert back to default.

Chatterino / chatterino2

Chat client for https://twitch.tv

MIT License

1.97k stars 443 forks source link

Dock Icon revert back to default. #3991

Closed reiryokusama closed 1 year ago

reiryokusama commented 1 year ago

Checklist

[X] I'm reporting a problem with Chatterino
[X] I've verified that I'm running the most recent nightly build or stable release
[X] I've looked for my problem on the wiki
[X] I've searched the issues and pull requests for similar looking reports

Describe your issue

I try to change Chatterino dock icon on my MacOS Monterey 12.6. When i open the application - it's revert the icon to default one. When i close the app - it's put back my custom icon. How to fix this? I tried to use also IconChamp and cDock. Tried to change icns in Resource folder of application.

Screenshots

SCR-20220916-9sx SCR-20220916-9tg

OS and Chatterino Version

Chatterino 2.3.5 (commit c6ebb70e modified) built with Qt 5.15.2 Running on macOS 12.6, kernel: 21.6.0

kageyama-h commented 1 year ago

This issue is also present on MacOS 13.0.1 Ventura, under M1 Pro.

kageyama-h commented 1 year ago

This issue may be circumvented by implementing #2204

LosFarmosCTL commented 1 year ago

This issue may be circumvented by implementing #2204

While there would be less incentive to change the icon after that is done, the core issue still remains. I remember looking into this since I have encountered it myself, but I got sidetracked by trying to fix the macOS icon situation as a whole and just forgot about the entire thing. I always wanted to fix both issues, but I can't promise anything will happen soon. Very busy with university right now, plus I am on vacation for 2 more weeks and don't have a computer with me.

Fwiw, the icon switching was caused by #3554, so an IFDEF around the setWindowIcon call to exclude macOS would fix this issue, setting the icon is kinda unnecessary anyways considering that it's already supposed to be included in the application bundle. Would have to be IFDEF'd out for macOS anyways as soon as the bundle gets a separate icon in the new style.

kageyama-h commented 1 year ago

I understand your predicament. In that case, perhaps it would be best to meet a compromise and just change the icon for the MacOS binary, and leave #3554 open.

LosFarmosCTL commented 1 year ago

I understand your predicament. In that case, perhaps it would be best to meet a compromise and just change the icon for the MacOS binary, and leave #3554 open.

Should not be an issue to just exclude that particular line of code for macOS, as I said it's kinda unnecessary anyways.

The icon changing was the part I failed at, generating the correct iconset file turned out to be a bit weird and I just forgot about it after I didn't manage to do it immediately 😁

The qt support article detailing how to set the actual icon in the end, after generating the iconset using iconutil if anyone wants to pick this up: https://doc.qt.io/qt-6/appicon.html