Chatterino / chatterino2

Chat client for https://twitch.tv
MIT License
2.07k stars 449 forks source link

Possible to have two nicknames for the same user. #4398

Open PsycloneTM opened 1 year ago

PsycloneTM commented 1 year ago

Checklist

Describe your issue

Similar to https://github.com/Chatterino/chatterino2/issues/2497 you can have two nicknames for the same person.

I assume this same fix that is being work on for https://github.com/Chatterino/chatterino2/issues/2497 could be applied to nicknames as well. ( https://github.com/Chatterino/chatterino2/pull/4322 )

Screenshots

image image

OS and Chatterino Version

Chatterino Nightly 7.4.1 (commit f6c90d99) built on 2023-02-20 with Qt 5.15.2, Windows SDK, MSVC 193431942, Crashpad Running on Windows 10 Version 2009, kernel: 10.0.22621

Mm2PL commented 1 year ago

This is a lot harder than the command issue as we have support for regex nicknames. Checking equivalence of regular expressions is a hard task (we'd need to implement basically a regex library) and I'd like for us to avoid that at all cost. The only way I can see this working is checking non-regex nicknames only and just ignoring the rest.