search

Chatterino / chatterino2

Chat client for https://twitch.tv
MIT License
2.02k stars 445 forks source link

fix: the version string not showing up as expected in Finder on macOS #5311

Closed nealxm closed 5 months ago

nealxm commented 5 months ago

Fixes #3283

according to apple the CFBundleGetInfoString plist key is not to be used. in old apple applications is used to be for showing the version which is why the current info string shows in the version field.

since the key has been replaced by NSHumanReadableCopyright i suggest removing the old key so that the version shows correctly in the get info window.

current: Screenshot 2024-04-09 at 15 53 20

proposed: Screenshot 2024-04-09 at 15 54 46

nealxm commented 5 months ago

Glad this fix worked! apologies I am not able to create a different pull request I should have pushed changes to different branches. Hope this is still okay

Felanbird commented 5 months ago

Glad this fix worked! apologies I am not able to create a different pull request I should have pushed changes to different branches. Hope this is still okay

It's not please go ahead and remove the contributor change from this PR, otherwise if there ends up being a problem with this PR we'll have to revert the commit, which contains your contributor addition.

As you mentioned for the future you should only make changes to separate branches, and keep your master branch out of it.

nealxm commented 5 months ago

apologies again for messing that up. should be all good now. thank you both again!