Chatterino / chatterino2

Chat client for https://twitch.tv
MIT License
1.98k stars 444 forks source link

Using filters on a Watching tab with a pre-existing chat open. Creates a unresponsive, unremovable box at the bottom of chat. #5327

Closed melon095 closed 3 months ago

melon095 commented 3 months ago

Checklist

Describe your issue

Opening a normal tab, then adding the same channel to the Watching tab, with a filter enabled creates a unclickable, unremovable black box at the bottom of chat.

Chatterino commit c391ff97.

Issue has been observed on Qt 6.7.0 and Qt 6.5.2 which was downloaded with the provided vcpkg.json file.

Im not entirely sure which commit made this occure. I previously used a build from a few months ago and just recently updated my build which is when this issue occured.

From my extensive testing, i've narrowed the issue down to having a semi large regex as a filter.

For example i used (message.content match r"^(?!.*(?:my|complex|(re.*x))).*$").

And every time i reloaded the Watching tab the issue would appear. Disabling filters or using something simpler as an empty regex or just message.length > 0 made this issue never appear.

Steps to reproduce

  1. Create a regex, for example (message.content match r"^(?!.*(?:my|complex|(re.*x))).*$")
  2. Create a tab with a live channel. (Issue wasn't observed on a offline chat).
  3. Create a Watching tab and apply the filter you created in step 1.
  4. Make the Watching tab open any random chat. Just not the one from step 2.
  5. Open the chat from step 2 in the Watching tab.
  6. The box should show up.

Screenshots

Animation

OS and Chatterino Version

Chatterino 2.5.0-beta.1 (commit c391ff97 modified) built with Qt 6.7.0, MSVC 193933523 Running on Windows 10 Version 21H1, kernel: 10.0.19043

pajlada commented 3 months ago

Thanks for the informative report!