2.5.0 deb files have version set to 0.0.0-dev for Ubuntu 22.04 and 20.04

timwaters commented 6 months ago

Checklist

[X] I'm reporting a problem with Chatterino
[X] I've verified that I'm running the most recent nightly build or stable release
[X] I've looked for my problem on the wiki
[X] I've searched the issues and pull requests for similar looking reports

Describe your issue

When trying to install a download of https://github.com/Chatterino/chatterino2/releases/download/v2.5.0/Chatterino-Ubuntu-22.04.deb on Ubuntu 23.10 it gives the warning:

dpkg: warning: downgrading chatterino from 2.4.5 to 0.0.0-dev

The version given in the deb file is 0.0.0-dev

dpkg -I Chatterino-Ubuntu-22.04.deb

 new Debian package, version 2.0.
 size 12000742 bytes: control archive=558 bytes.
     868 bytes,     9 lines      control
 Package: chatterino
 Version: 0.0.0-dev
 Architecture: amd64
 Maintainer: Mm2PL <mm2pl@kotmisia.pl>
 Depends: libc6, libstdc++6, libglx0, libopengl0, libpng16-16, libharfbuzz0b, libfreetype6, libfontconfig1, libjpeg-turbo8, libxcb-glx0, libegl1, libx11-6, libxkbcommon0, libx11-xcb1, libxkbcommon-x11-0, libxcb-cursor0, libxcb-icccm4, libxcb-image0, libxcb-keysyms1, libxcb-randr0, libxcb-render-util0, libxcb-shm0, libxcb-sync1, libxcb-xfixes0, libxcb-render0, libxcb-shape0, libxcb-xkb1, libxcb1, libbrotli1, libglib2.0-0, zlib1g, libicu70, libpcre2-16-0, libssl3, libgraphite2-3, libexpat1, libuuid1, libxcb-util1, libxau6, libxdmcp6, libbrotli1, libffi8, libmount1, libselinux1, libpcre3, libicu70, libbsd0, libblkid1, libpcre2-8-0, libmd0
 Section: net
 Priority: optional
 Homepage: https://github.com/Chatterino/chatterino2
 Description: Ubuntu package built for 22.04

(Also the size of the new 2.5.0 file is significantly larger: 11.4mb compared to 3.4mb for a v2.4 deb file which worried me a little when this didnt install but I guess this is intentional, extra icons etc)

Screenshots

No response

OS and Chatterino Version

Chatterino 2.4.4 Running on Ubuntu 23.10

Mm2PL commented 6 months ago

~~This is probably because this the CI checkout does not include tags.~~

It's worth noting that we've had packaging issues with deb since forever. Now that I'm looking at this: deb packaging generates way more problems than it needs to. We shouldn't ever have been packaging Chatterino for Ubuntu ourselves. Nevertheless I'll get my Ubuntu stuff back up to fix this crap.

Update(2024-04-21 23:00:00Z): This is caused by permissions being fucked in the directory. Git doesn't like the checkout directory being owned by a different UID or something like that apparently.

Wissididom commented 6 months ago

The stuff with not including tags should already be handled by the fetch-depth: 0 option we've specified for the actions/checkout action inside the workflow file, so I guess there is something else too. But we could try setting fetch-tags to true additionally (https://github.com/actions/checkout/blob/main/README.md).

pajlada commented 6 months ago

(Also the size of the new 2.5.0 file is significantly larger: 11.4mb compared to 3.4mb for a v2.4 deb file which worried me a little when this didnt install but I guess this is intentional, extra icons etc)

We now statically link to Qt & Boost - this is what has caused the file size increase

https://github.com/Chatterino/docker is the repo that contains the two docker images we use to build Chatterino here (the readme is bad, the github workflow in the main c2 repo actually show how they can be used)

Chatterino / chatterino2