search

Chatterino / chatterino2

Chat client for https://twitch.tv
MIT License
2.04k stars 449 forks source link

fix(notebook): align actions and hotkeys #5353

Closed Nerixyz closed 2 months ago

Nerixyz commented 5 months ago

Aligns Ctrl+U and "Toggle visibility of tabs" to do the same. The hotkey will now trigger the same QAction. I've done the same for Ctrl+Shift+L and removed the visibility filter reset when the hotkey is activated with on or off.

Fixes #5341.

Nerixyz commented 5 months ago

What does it mean to toggle the tab live only state? imo it means you toggle between whatever state it was in before (1 or 3) and 2

That's what's happening:

graph TD;
    All<-->|toggleLive|LiveOnly
    NoneAll<-->|toggleAll|All
    NoneAll-->|toggleLive|LiveOnly
    NoneLive-->|toggleAll|LiveOnly
    NoneLive<-->|toggleLive|All

In addition to some of the changes you've done, I propose the tab visibility is moved to a submenu with 3 always visible options matching the three states of tab visibility.

I'm unsure about this.

  1. Hide all tabs (Linked to the hotkey Set tab visibility -> Set to off)
  2. Show live tabs only (Linked to the hotkey Set tab visibility -> Live only on)
  3. Show all tabs (Linked to the hotkey Set tab visibility -> Set to on)

Should be "Tab Visibility" → {All, Live Only, None}.

The downside I see to the above-mentioned change is we no longer surface the default toggle hotkeys. This could be alleviated by adding 2 more options for the toggling

This also breaks the workflow of right-clicking and clicking on the desired option, as you now have to move through the submenu.

Use submenus sparingly. Each submenu adds complexity to the interface and hides the items it contains. You might consider creating a submenu when a term appears in more than two menu items in the same group.

pajlada commented 2 months ago

Closing in favour of https://github.com/Chatterino/chatterino2/pull/5530 - thanks for helping brainstorm