Chatterino / chatterino2

Chat client for https://twitch.tv
MIT License
1.97k stars 442 forks source link

feat(emote-popup): save size of popup #5415

Closed Nerixyz closed 1 month ago

Nerixyz commented 1 month ago

I don't know if this PR completely resolves #5414, but it does fix some bugs related to Qt's frameMargins that are added even though we're a frameless window (probably a Qt bug - I'll try to reproduce and report it). As mentioned in #5414, the emote-popup doesn't remember its position if the main window is closed while the popup is open. This PR fixes that bug as well.

As mentioned in https://github.com/Chatterino/chatterino2/issues/5414#issuecomment-2123260324, saving the width and height of the popup in addition to its position is reasonable. The position is now remembered correctly without Qt's invisible margins (geometry doesn't have that "bug"). The only tiny issue I can see is closing Chatterino with the popup open can cause the position to be off by a few pixels because of the delayed bounds on Windows, however, I don't really think this is a major issue.

Fixes #5414.