Opening usercards from system messages uses "multichannel" channel context

jupjohn commented 2 weeks ago

Checklist

[X] I'm reporting a problem with Chatterino
[X] I've verified that I'm running the most recent nightly build or stable release
[X] I've looked for my problem on the wiki
[X] I've searched the issues and pull requests for similar looking reports

Describe your issue

When searching through the global "all channel" search and opening the usercard from a system message (e.g. a ban), the usercard opens a popout URL with the channel name "multichannel"

Screenshots

OS and Chatterino Version

Chatterino 2.5.1 (commit f42bb7312) built with Qt 6.7.2 Running on Arch Linux, kernel: 6.10.6-zen1-1-zen

Mm2PL commented 2 weeks ago

Can replicate after some fiddling. The global search is a crucial part of this.

Chatterino 2.5.1 DEBUG (commit 9a8e943e7 modified) built with Qt 5.15.14 Running on Arch Linux, kernel: 6.10.6-arch1-1

Mm2PL commented 2 weeks ago

This makes sense because the user card is opened with the context of the multichannel search, it just doesn't know that its primary channel is where the user was banned. You can see the usercard has the name %s's Usercard - #multichannel.

Same is true for twitch user pages opened via middleclicking a username (but not when opening one through the usercard).

Chatterino / chatterino2