Chatterino / chatterino2

Chat client for https://twitch.tv
MIT License
2.07k stars 449 forks source link

chore: keep GDI fontengine on Windows for now #5710

Closed Nerixyz closed 2 weeks ago

Nerixyz commented 2 weeks ago

From https://github.com/Chatterino/chatterino2/issues/5694: The DirectWrite font engine in Qt 6.8.0 doesn't match the behavior of the old GDI engine. As explained in https://github.com/Chatterino/chatterino2/issues/5694#issuecomment-2455665969, I filed QTBUG-130861, but that won't be fixed until at least 6.8.2 (most likely - 6.8.1 is to be released on 21st of November). The issue doesn't affect the default configuration on Windows that uses Segoe UI as it has a style for the 600 weight. Only fonts that don't have a style for the 600 weight are affected.

Currently, we don't gain much by using DirectWrite exclusively (note the DirectWrite is already used for some fonts that require it - it's also used in the linked issue), so I disabled that fontengine by default. Users can still opt-out by disabling CHATTERINO_USE_GDI_FONTENGINE.

I also removed the dpiawareness=2 as this was never read, because the key was wrong (WindowArguments had the s in Windows missing).