search

Chaython / volumecontrol

Firefox extension, that can boost the audio volume beyond the normal maximum.
ISC License
41 stars 5 forks source link

Mutes Clips on clips.twitch.tv #14

Open Xzaven opened 2 months ago

Xzaven commented 2 months ago

Hey, so the volume control is working great to adjust the volume for streams on twitch! Thanks!

However for some reason all the clips on clips.twitch.tv are muted as long as the addon is active. Tested by opening them in incognito mode and disallowing the addon there. Any fix or workaround for this without having to use incognito mode or 2nd browser?

Chaython commented 2 months ago

IDK how to view clips.twitch.tv it's just directing to twitch.tv Can you please link a specific clip? I don't use twitch... Regardless if you know the domain, you can add it to your exclusion list. Click volume control, click settings and add the URL of the site where playback error occurs. Usually it's an issue with CSP.

Xzaven commented 2 months ago

Oh right, a link would have been smart. https://www.twitch.tv/cohhcarnage/clip/CogentSpeedyFloofM4xHeh-o5gM-7q9NoGKJcRe

As you can see from the domain in this case, blacklisting the domain poses a problem, because https://www.twitch.tv/cohhcarnage is the domain of the channel/stream, which works fine. It is only the clips part that isn't working, so I'd need to add an exclusion every time I'd want to watch a clip on a channel that isn't excluded yet. It would be a workaround for the creation of clips though, which is done on clips.twitch.tv/create, but I can't put a link to that here as it immediately redirects the domain address from a coded one to the clips.twitch.tv/create.

And I just noticed that blacklisting isn't possible for pages that do not start with www , so I could only blacklist the whole of twitch, which I don't want cause I got the extension specifically to adjust/balance the volume of streams. grafik

Chaython commented 2 months ago

The www. Prefix was to make it easier to just type blah.com rather than having to type www.blah.com The way the thing works it needed the context of www. For some inconvenient reason... Tomorrow I will check if HTTPS:// works rather than www. As a prefix Though usually www. Is inferred and your context shouldn't matter... The cdn is usually the source of the csp and HTTPS should also be inferred

Chaython commented 2 months ago

Sorry I had a busy week, I was busy dating.... Anyways I looked into the domain for clips seems to be production.assets.clips.twitchcdn.net So blacklist that domain, and disable "Access your data for all websites" Because the video is loading in the frame, if you initialize the extension [clicking on it] it will break audio again... So if you were already viewing twitch with the extension enabled you would need to ctrl F5 to reset the extension / page if you had initialized the extension previously.

Chaython commented 2 months ago

Green icon means the extension is uninitialized https://github.com/Chaython/volumecontrol/assets/6486343/1ff05574-8680-4341-b589-f2cb9249441d

Xzaven commented 1 month ago

So blacklisting the domain doesn't seem to do anything, maybe because it always automatically changes it to www.production.assets.clips.twitchcdn.net ? But removing the "Access your data for all websites" does the trick, thanks for the help!