search

Chaython / volumecontrol

Firefox extension, that can boost the audio volume beyond the normal maximum.
ISC License
42 stars 5 forks source link

Feedback #6

Open Chaython opened 1 year ago

Chaython commented 1 year ago

If you want to comment about changes to my extension, please comment here. Don't be shy. I'm always looking for feedback or insight.

nodthenbow commented 1 year ago

Having a url whitelist/blacklist would be useful since this extension conflicts with other audio extensions (big one for me is frankerfacez's audio compressor for twitch being broken by this extension). There's currently ways to get the same effect by mucking with permissions in firefox, but it barely works.

Chaython commented 1 year ago

The default behavior is to only initiate when clicked, so it shouldn't interfere with other plugins. But when I search up FFZ AC I see a lot of reports of lagging etc. If it's initiating before being clicked on a tab, try toggling permissions off in about:addons > Volume Control > permissions There's some issues with FF permissions. That are unrelated to the plugin. Green icon means it's not initialized on the current tab/site image image

suspiciousRaccoon commented 11 months ago

Heya! would it be possible to save a default starting volume per page? As discussed here. I'm not experienced with extensions, but an approach to do this could be having a toggle and saving the setting to localstorage.

refatK commented 11 months ago

Found a bug I think. I was on a website and noticed there was no audio on the video, and confirmed that disabling the extension fixed it. Looking at the browser console I saw the following:

The HTMLMediaElement passed to createMediaElementSource has a cross-origin resource, the node will output silence

It happened here btw: https://store.steampowered.com/app/1296980/Forgotten_Fields/

Chaython commented 11 months ago

Found a bug I think. I was on a website and noticed there was no audio on the video, and confirmed that disabling the extension fixed it. Looking at the browser console I saw the following:

The HTMLMediaElement passed to createMediaElementSource has a cross-origin resource, the node will output silence

It happened here btw: https://store.steampowered.com/app/1296980/Forgotten_Fields/

Thanks for noticing a bug. Default behavior is to not load the plugin, until clicked. Unless the site is whitelisted. If you have not granted access to all data. So you will lose audio if you initiate it. As a temporary work around you can just not initiate it on the site.

ameameam3 commented 10 months ago

Heya! would it be possible to save a default starting volume per page? As discussed here. I'm not experienced with extensions, but an approach to do this could be having a toggle and saving the setting to localstorage.

seconding this. domain-wide settings would be nice. as well as a persistent setting, i have to set the volume back up every time the URL changes even a little bit on video streaming websites.

Edit: Sorry, seems like in my case the issue is that it turns off whenever the URL changes. If we could maybe have an option for Auto-Starting it at a certain volume (like a save button), that would be nice.

cokeb commented 8 months ago

Cosmetic "issue". Would it be possible to change the +X dB text to +X %?

Chaython commented 8 months ago

Cosmetic "issue". Would it be possible to change the +X dB text to +X %?

As you don't know the volume of the input, for example your video may be set to 50% output. I don't know the total percentage. We could set 0 to 100% for example as it's 100% of the content's output, but it would be inaccurate presumption. Further, Gain node can have an infinite number according to Mozilla documentation, so it would also not be an accurate depiction of the underlying code, as it relies on dB an arbitrary number that has been locked to +/-32db not a variable percentage.

So like 100% could be the max of the slider but it doesn't represent the underlying equation.

The reason why other extensions give a percentage is because they edit the actual webpage, my extension works in browser not in page. 600_sound_volume-1.5.5 also seems to inject ads from alibaba. Which is why I contributed to this in the first place.

wtfiwinomgs commented 8 months ago

possible to add support of what stated above? +1 from me on saving settings for some saved/often visited sites.

further more, requesting a feature of adding hotkeys support would be really nice.

take video speed controller as an example, has both saved settings for sites as well as +/- for hotkeys to speed up/down the video. would be super nice if we can assign our own hotkeys for audio as well to not duplicate +/-

boobthecat commented 7 months ago

+1 for persisted settings

philfycasual commented 4 months ago

+1 for persisted settings

Could definitely benefit from persistent settings, ideally on a per-site basis.