search

Chdata / Versus-Saxton-Hale

The presuccessor of FF2(FF2 is the successor of VSH)
GNU General Public License v3.0
11 stars 6 forks source link

Hale gibs material download. #2

Closed jackemerson closed 9 years ago

jackemerson commented 9 years ago

The line (191) for adding the download is "materials/models/player/saxton_test4/haleGibs.vmt", The file isn't capitalised though and I believe this causes an issue.

Starblaster64 commented 9 years ago

From what I've read on the AlliedModders forums, capitilising file names causes compatibility issues with Linux servers so the file is correct, and line(191) is in the wrong.

Also I believe Chdata should have removed the Hale gibs until further notice, as noted in commit 59d79e8, I suppose he simply ignored/forgot the material files.

Chdata commented 9 years ago

I left that material file in, as I wasn't sure if any of the other materials used it or not - like how the old Hale materials are actually used for CBS as well and are still included.

And yes, I wish it were all lowercase, but thePFA still capped it for some reason.

Chdata commented 9 years ago

Either way the gibs aren't in (models) and if it's only the gib material that's broken it's not a pressing issue as it's unused anyway.

jackemerson commented 9 years ago

Ah, yeah, I just updated the line in my code when I noticed it to stop the download request each map.

@Starblaster64 In regards to capitalising causing issues, is that only if the code doesn't match case exactly or would you want to avoid having actual files capitalised on Linux?

Starblaster64 commented 9 years ago

@Advkt Chdata is probably better qualified to answer that, but I would probably guess the latter.

Chdata commented 9 years ago

While it may be unnecessary, I believe it's best for all files to be all lowercase, _underscore instead of space, and [a-zA-Z1-0], or however that goes. At the very least, you won't ever run into problems doing that.

But yeah if it is trying to download something that's not there I guess I'll comment it out.

Chdata commented 9 years ago

Closed by https://github.com/Chdata/Versus-Saxton-Hale/commit/013f849a3a7cd9c59b6616699e87c4a79e3acf84