CheckPointSW / CheckPointAnsibleMgmtCollection

This Ansible collection provides control over a Check Point Management server using Check Point's web-services APIs.
https://galaxy.ansible.com/check_point/mgmt
Apache License 2.0
40 stars 30 forks source link

Tagged releases do not correspond to Galaxy tarballs #84

Closed felixfontein closed 2 years ago

felixfontein commented 2 years ago

While investigating https://github.com/ansible/ansible/pull/78755 I noticed that the collection repository and the tagged releases do contain different meta/runtime.yml files than the Galaxy tarbals on https://galaxy.ansible.com/check_point/mgmt.

For example, meta/runtime.yml for 3.2.0 on Galaxy contains a meta/runtime.yml containing:

requires_ansible: '>=2.11'  # force ansible-doc to check the Ansible version (requires packaging)
plugin_routing:
  modules:
    hi:
      redirect: hello

While this repository - and its v3.2.0 tag - contains a meta/runtime.yml as follows:

requires_ansible: '>=2.9.10'

(https://github.com/CheckPointSW/CheckPointAnsibleMgmtCollection/blob/v3.2.0/meta/runtime.yml)

Please note that this violates the rules for inclusion in Ansible (https://github.com/ansible-collections/overview/blob/main/collection_requirements.rst#repository-management).

Also this redirect you are including in the released version does not make sense and should not be there anyway, and you stlil state that your collection works with Ansible 2.9 or later, while it will (due to meta/runtime.yml) now generate errors with ansible-base 2.10 (Ansible 2.9 does not have the facilities to generate such errors) claiming that this version isn't supported.

chkp-edenbr commented 2 years ago

Thank you for notifying us, we'll update the file

chkp-edenbr commented 2 years ago

Issue fixed in new release v4.0.0.

felixfontein commented 2 years ago

Are you sure? I downloaded the tarball from the v4.0.0 tag in this repository and compared it to the tarball of the 4.0.0 release from Galaxy.

meta/execution-environment.yml is a valid YAML file in the Galaxy tarball, but somehow indented and has a different content (build_arg_defaults is present in the repo, but not in the Galaxy tarball) in this repo: https://github.com/CheckPointSW/CheckPointAnsibleMgmtCollection/blob/master/meta/execution-environment.yml

Also CHANGELOG.rst differs between the two tarballs.

Finally the changelogs/, docs/, roles/, and tests/integration/ directories are present in the Galaxy tarball, but not in this repository. Also tests/units/modules/ contains two files in the Galaxy tarball that are not present in this repository.

chkp-edenbr commented 2 years ago

Thank you, we will make sure this will be fixed in future release