CheckPointSW / Karta

Karta - source code assisted fast binary matching plugin for IDA
MIT License
862 stars 103 forks source link

'year' variable referenced before assignment in libjpeg.py,line:34 #57

Open hackoflpf opened 3 years ago

chkp-eyalit commented 3 years ago

Hi, I went over the code and the only case in which "year" isn't being initialized before it is being references is if the "wanted_string" doesn't match the expected format. This means that the library would anyway won't recognize the version in this case.

It would help if you could supply the version with which you tested Karta, or preferably a debug print of the "wanted_string" variable (right after line 29).

I really doubt that I will manage to integrate a fix to this issue (see my last commit), but if you will send me the debug print I asked for in the near future (few hours) I might be able to make it.

hackoflpf commented 3 years ago

emm,i just use git to download the whole project, then i test karta_identifier.py on ida pro 7.5,it doesn't work because of the problem i mentioned before.You can just change the indent of 'year' in line34,the problem is in src/libs/libjpeg.py. image

hackoflpf commented 3 years ago

image