search

CheckPointSW / terraform-provider-checkpoint

Terraform provider for Check Point
https://www.terraform.io/docs/providers/checkpoint/
Mozilla Public License 2.0
28 stars 40 forks source link

Add session-timeout to provider arguments #136

Closed paulzerkel closed 1 year ago

paulzerkel commented 1 year ago

This PR adds session-timeout to the provider arguments. We ran into a case where our overall Terraform apply phase was longer than the default of 600 seconds, which resulted in failure due to the session being invalid. I did not see the valid range for session-timeout in the API documentation, but when I set it to 6000 I received an error that it was only valid from 10-3600, so the code and docs reflect that.

This PR also contains one commit that formats the code based on the result of make fmt, so this may be easier to review by commit.

paulzerkel commented 1 year ago

Thanks for your contribution to this project. It's a nice feature. I left some comments in the PR, please fix and I will review again.

Thanks for the review! Commit c463dea should account for all of the requested changes.

chkp-royl commented 1 year ago

Thanks for your contribution to this project. It's a nice feature. I left some comments in the PR, please fix and I will review again.

Thanks for the review! Commit c463dea should account for all of the requested changes.

Changes look good now. Thanks! Can you make new PR with only the required changes? We prefer not to commit files that are not relevant for this change (with all the code format).

paulzerkel commented 1 year ago

Thanks for your contribution to this project. It's a nice feature. I left some comments in the PR, please fix and I will review again.

Thanks for the review! Commit c463dea should account for all of the requested changes.

Changes look good now. Thanks! Can you make new PR with only the required changes? We prefer not to commit files that are not relevant for this change (with all the code format).

I have rebased to remove the commit for gofmt. Please let me know if you have any other feedback!

chkp-royl commented 1 year ago

PR looks good now, this feature will be available on our next release. Thank you for contributing for the Check Point provider. Merged.