Checkmarx / ast-cli

A CLI project wrapping application security testing (AST) APIs
Apache License 2.0
41 stars 25 forks source link

Remove default from unsupported agents for SCS results (AST-68004) #912

Closed Korjen97 closed 3 weeks ago

Korjen97 commented 1 month ago

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Removed the DefaultAgent from the unsupportedTypesByAgent map in the filterScsResultsByAgent function because it supports all result types (SCSScorecardType and SCSSecretDetectionType). Since its exclusion list was empty, its presence in the map was redundant. This change simplifies the code without affecting functionality, as DefaultAgent never excluded any result types.

References

https://checkmarx.atlassian.net/browse/AST-68004

Testing

Describe how this change was tested. Be specific about anything not tested and reasons why. If this solution has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Checklist

github-actions[bot] commented 1 month ago

Logo Checkmarx One – Scan Summary & Details13450b87-5f89-4356-ad9f-0d77d08978d2

No New Or Fixed Issues Found