Checkmarx / kics-github-action

GitHub actions of KICS scan - Keeping Infrastructure as Code Secure
https://kics.io
GNU General Public License v3.0
43 stars 33 forks source link

PR annotations stopped working after upgrading to version v1.6.1 #77

Closed kazaker closed 1 year ago

kazaker commented 1 year ago

Hey Team, thank you for a great tool. I'm facing a small problem after upgrading to v1.6.1. Before that PR comments and annotations worked fine, but after it I see only comment, annotations are gone. I don't see any apparent error in task log, other that this:

Results Summary: HIGH: 0 MEDIUM: 0 LOW: 0 INFO: 6 TOTAL: 6

Results saved to file scanResults/results.json Scan duration: 21.428828286s A new version 'v1.6.5' of KICS is available, please consider updating fetch https://dl-cdn.alpinelinux.org/alpine/v3.16/main/x86_64/APKINDEX.tar.gz fetch https://dl-cdn.alpinelinux.org/alpine/v3.16/community/x86_64/APKINDEX.tar.gz (1/7) Installing c-ares (1.18.1-r0) (2/7) Installing libgcc (11.2.1_git20220219-r2) (3/7) Installing icu-data-en (71.1-r2) Executing icu-data-en-71.1-r2.post-install *

added 34 packages, and audited 35 packages in 3s

2 high severity vulnerabilities

To address all issues, run: npm audit fix

Run npm audit for details.

kics-github-action@1.0.0 build ncc build src/main.js

ncc: Version 0.31.1 ncc: Compiling file index.js into CJS 791kB dist/index.js 791kB [4292ms] - ncc 0.31.1 Running KICS action... (node:63) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead. (Use node --trace-deprecation ... to show where the warning was created) KICS scan status code: 0

Doesn't work irregardless of setting enable_annotations variable explicitly to true or leaving it by default.

Could you please help me with that?

joaoReigota1 commented 1 year ago

Hi @kazaker, thank you for bringing this issue to our attention. It seems there was a bug in the javascript, as the name of the env called for annotations was incorrect. There is already a PR opened to fix this issue. Thank you

JamesHaughey commented 1 year ago

Do you know when this fix will published in a release? I'm having to run against the 'master' branch right now and would very much prefer to use a non-mutable tag.