Closed SevenEarth closed 2 weeks ago
Hi @SevenEarth ,
Thank you very much for this contribution!! We'd like to request you 2 steps:
Kindly take a look at the failing tests
Please add a prefix "(Beta)
" to the queries name, like in this one. For now we need this because when all the tests pass we will merge this PR, but the queries will need to be reviewed by our AppSec later on as well. This "(Beta)
" prefix will help the users to know that this queries are part of KICS but they are still under review.
Hi @SevenEarth ,
Thank you very much for this contribution!! We'd like to request you 2 steps:
- Kindly take a look at the failing tests
![]()
- Please add a prefix "
(Beta)
" to the queries name, like in this one. For now we need this because when all the tests pass we will merge this PR, but the queries will need to be reviewed by our AppSec later on as well. This "(Beta)
" prefix will help the users to know that this queries are part of KICS but they are still under review.
Hello, Thank you for your review.
I have a question about the first bug:
I ran the following code locally for testing, and the result was normal without any errors
go run ./cmd/console/main.go scan -p "/Users/yanxiang/Tencent/Kics/kics/assets/queries/terraform/tencentcloud/cvm_instance_has_public_ip/test" -d "/Users/yanxiang/Tencent/Kics/kics/assets/queries/terraform/tencentcloud/cvm_instance_has_public_ip/test/input.json"
May I ask where is the detailed log of the failed e2e test? I want to see the reason for the error?
ohhh, I guess it's probably a 'module' issue
@SevenEarth , the unit-tests are the ones that are failing. The e2e is failing because another reason, do not worry! :D Seems like what you expected to happen in your positive_expected_result.json is not happening, for all the 4 new queries added.
@SevenEarth , the unit-tests are the ones that are failing. The e2e is failing because another reason, do not worry! :D Seems like what you expected to happen in your positive_expected_result.json is not happening, for all the 4 new queries added.
Thank you I fix all problems There is my local test Please help review the PR 😁
@SevenEarth , thank you for this amazing contribution!!
Hello, There is something new query for TencentCloud CVM resource:
Please help review the PR Thanks
I submit this contribution under the Apache-2.0 license.