search

Cheedoong / xml2json

A header-only C++ library converts XML to JSON
MIT License
299 stars 100 forks source link

Small issue with empty control statement #11

Closed sturmf closed 8 years ago

sturmf commented 8 years ago

In rapidxml.hpp there is a small issue with a control statement. In line 516 you have:

        if (!m_nullstr);
            m_nullstr = allocate_string("");
        return m_nullstr;

As you can see there is a semicolon after the if statement. The consequence is that the m_nullstr is allocated every time it passes this sequence.

Cheedoong commented 8 years ago

@sturmf fixed with thanks!