CheeseKingu / Loot-Modifiers

Copy this stack to start editing your FixedItems
12 stars 4 forks source link

0.95 overriding behaves differently #5

Open zhawzid-ottj opened 11 months ago

zhawzid-ottj commented 11 months ago

overriding seem to behave differently in 0.95

I have a folder with all overridden spawner files and no Zones.json should override for whole map (as it did before 0.95)

example:

Street-Residential-Examine_Car_Wreck_Scrap.json contains "QuantityMin": 1, "QuantityMax": 1,

should spawn 1 scrap (as it did before 0.95) now spawns 2 (like default) also InitialDamage and RandomDamage doesn't seem to work properly

Is it the missing Zones.json (which should be fine) or what could be my problem here?

CheeseKingu commented 11 months ago

Hello there,

I can't seem to reproduce this issue whatsoever. I have placed this in the override and it seems to work fine. The spawner preset configuration below will give me 1 scrap always.

{ "Items": [ { "Rarity": "Uncommon", "Id": "Metal_Scrap_01" }, { "Rarity": "Uncommon", "Id": "Metal_Scrap_02" }, { "Rarity": "Uncommon", "Id": "Metal_Scrap_03" }, { "Rarity": "Uncommon", "Id": "Metal_Scrap_04" }, { "Rarity": "Uncommon", "Id": "Metal_Scrap_05" } ], "QuantityMin": 1, "QuantityMax": 1, "AllowDuplicates": true, "ShouldFilterItemsByZone": false, "InitialDamage": 0, "RandomDamage": 30, "InitialUsage": 0, "RandomUsage": 0, "PostSpawnActions": [ "SetAmmoAmount_SmallStash", "SetCashAmount_SmallStash", "SetClothesDirtiness_DirtyClothes" ] }

zhawzid-ottj commented 11 months ago

I was able to fix it. I think it was the GeneralZoneModifiers.json

{ "Modifiers": [ { "SpawnerProbabilityMultiplier": 1.0, "ExamineSpawnerProbabilityMultiplier": 1.0, "ExamineSpawnerQuantityMultiplier": 1.0 } ] }

...which I deleted now. Before 0.95 it behaved differently, zones had priority, now it seems this file has priority (and applies based on vanilla x1 even if override files set QuantityMin to 1 and QuantityMax to 1) Because of the file date and the backup I have I'm sure it was there before 0.95

CheeseKingu commented 11 months ago

Hello there,

GeneralZoneModifiers.json has always taken priority.

zhawzid-ottj commented 11 months ago

always: based on vanilla or based on after parsing spawner files?

If based on after applying override files it should have been QuantityMin=1 and QuantityMax=1 for my example but it wasn't. Got 2 scrap. Now I'm getting 1 scrap which is correct. Before 0.95, even with this very same GeneralZones.json I got 1 scrap as well.

So I might have been applied it the wrong way before 0.95 but it somehow worked.

CheeseKingu commented 11 months ago

Hello there,

It was always taking priority, it overrides the zone itself. I'm guessing it was applied wrong before 0.95. but I can't know that without your entire loot folder.

zhawzid-ottj commented 11 months ago

Thanks, I'm sure you're right. The same GeneralZones.json was parsed as well before 0.95 (still have old loot.log files) but didn't affect my override scenario. Now it does - at least for override files that have no Zones.json with them

CheeseKingu commented 11 months ago

Hello there,

I see, I will check this out for the zones itself. Is there anything else I can help you out with?

zhawzid-ottj commented 11 months ago

I'm fine - thank you very much for your time and your quick responses.

CheeseKingu commented 11 months ago

Thank you :). No problem of course.