Cheesehyvel / magesim-tbc2

MageSim TBC in C++
MIT License
9 stars 18 forks source link

Fix empty histogram when values span below and above 1000 #5

Closed jhenry82 closed 3 years ago

jhenry82 commented 3 years ago

I noticed if the range of DPS values spans above and below 1000 (say 800-1100) the histogram is empty. This is because the code was sorting the keys alphabetically and I guess the chart component doesn't handle them being out of order well.

This just sorts the keys numerically instead which fixes the histogram.

Cheesehyvel commented 3 years ago

Added my own commit, because this PR made changes to the binary and I don't know why.

88ab962