search

Cheesehyvel / magesim-tbc2

MageSim TBC in C++
MIT License
9 stars 18 forks source link

Drums of Restoration not applying additional MP5 #9

Closed yurpcraft closed 3 years ago

yurpcraft commented 3 years ago

Pretty simple test for this. Look at your mana regen with permanent drums enabled, then deselect drums. MP5 in the combat log remains the same, when there should be a significant mana regen difference.

Here's an example log with no drums

Time | Mana | DPS | Event
-- | -- | -- | --
01.00 | 15126 (100%) | 0 | Gained 50 mana from Vampiric Touch
02.00 | 15126 (100%) | 0 | Gained 210 mana from Mana Regen
02.00 | 15126 (100%) | 0 | Gained 50 mana from Vampiric Touch
02.50 | 14931 (99%) | 1430 | Arcane Blast crit for 3574
02.50 | 15005 (99%) | 1430 | Gained 74 mana from Judgement of Wisdom
02.50 | 15005 (99%) | 1430 | Gained Lightning Capacitor (1)
02.50 | 15005 (99%) | 1430 | Gained Arcane Blast (1)
03.00 | 15055 (100%) | 1191 | Gained 50 mana from Vampiric Touch
04.00 | 15126 (100%) | 894 | Gained 142 mana from Mana Regen
04.00 | 15126 (100%) | 894 | Gained 50 mana from Vampiric Touch
04.67 | 15085 (100%) | 1551 | Gained 300 mana from Mana Restore (meta)
04.67 | 15085 (100%) | 1551 | Arcane Blast crit for 3666
04.67 | 15126 (100%) | 1551 | Gained 74 mana from Judgement of Wisdom
04.67 | 15126 (100%) | 1551 | Gained Lightning Capacitor (2)
04.67 | 15126 (100%) | 1551 | Gained Arcane Blast (2)
05.00 | 15126 (100%) | 1448 | Gained 50 mana from Vampiric Touch
06.00 | 15126 (100%) | 1207 | Gained 142 mana from Mana Regen
06.00 | 15126 (100%) | 1207 | Gained 50 mana from Vampiric Touch
06.50 | 14638 (97%) | 1681 | Arcane Blast crit for 3687
06.50 | 14638 (97%) | 1681 | Gained Lightning Capacitor (3)
06.50 | 14638 (97%) | 1681 | Lost Lightning Capacitor
06.50 | 14638 (97%) | 1681 | Gained Arcane Blast (3)
06.50 | 14638 (97%) | 1681 | Lightning Capacitor was resisted
07.00 | 14688 (97%) | 1561 | Gained 50 mana from Vampiric Touch
08.00 | 14830 (98%) | 1366 | Gained 142 mana from Mana Regen
08.00 | 14196 (94%) | 1838 | Arcane Blast crit for 3779
08.00 | 14246 (94%) | 1838 | Gained 50 mana from Vampiric Touch
09.00 | 14296 (95%) | 1634 | Gained 50 mana from Vampiric Touch
09.50 | 13662 (90%) | 1926 | Arcane Blast crit for 3590
09.50 | 13662 (90%) | 1926 | Gained Lightning Capacitor (1)
10.00 | 13803 (91%) | 1830 | Gained 142 mana from Mana Regen
10.00 | 13853 (92%) | 1830 | Gained 50 mana from Vampiric Touch

Compared with drums:


Time | Mana | DPS | Event
-- | -- | -- | --
00.00 | 15126 (100%) | 0 | Gained Drums of Restoration
01.00 | 15126 (100%) | 0 | Gained 50 mana from Vampiric Touch
02.00 | 15126 (100%) | 0 | Gained 210 mana from Mana Regen
02.00 | 15126 (100%) | 0 | Gained 50 mana from Vampiric Touch
02.50 | 14931 (99%) | 846 | Arcane Blast hit for 2116
02.50 | 15005 (99%) | 846 | Gained 74 mana from Judgement of Wisdom
02.50 | 15005 (99%) | 846 | Gained Arcane Blast (1)
03.00 | 15055 (100%) | 705 | Gained 50 mana from Vampiric Touch
04.00 | 15126 (100%) | 529 | Gained 142 mana from Mana Regen
04.00 | 15126 (100%) | 529 | Gained 50 mana from Vampiric Touch
04.67 | 14785 (98%) | 914 | Gained Clearcast
04.67 | 14785 (98%) | 914 | Arcane Blast hit for 2150
04.67 | 14785 (98%) | 914 | Gained Arcane Blast (2)
05.00 | 14835 (98%) | 853 | Gained 50 mana from Vampiric Touch
06.00 | 14977 (99%) | 711 | Gained 142 mana from Mana Regen
06.00 | 15027 (99%) | 711 | Gained 50 mana from Vampiric Touch
06.50 | 15027 (99%) | 1221 | Lost Clearcast
06.50 | 15027 (99%) | 1221 | Arcane Blast crit for 3672
06.50 | 15027 (99%) | 1221 | Gained Lightning Capacitor (1)
06.50 | 15027 (99%) | 1221 | Gained Arcane Blast (3)
07.00 | 15077 (100%) | 1134 | Gained 50 mana from Vampiric Touch
08.00 | 15126 (100%) | 992 | Gained 142 mana from Mana Regen
08.00 | 14492 (96%) | 1251 | Arcane Blast hit for 2070
08.00 | 14542 (96%) | 1251 | Gained 50 mana from Vampiric Touch
09.00 | 14592 (96%) | 1112 | Gained 50 mana from Vampiric Touch
09.50 | 13958 (92%) | 1269 | Arcane Blast hit for 2047
10.00 | 14100 (93%) | 1206 | Gained 142 mana from Mana Regen
10.00 | 14150 (94%) | 1206 | Gained 50 mana from Vampiric Touch

That said - I'm not sure how much this is worth investing in since "Permanent Drums" is no longer an option per the Tinnitus Bluepost

Cheesehyvel commented 3 years ago

e5067ad83e561358fcd410f3a6a0d89e3bd822d2