ChefKissInc / NootedRed

The AMD Vega iGPU support patch kext. No commercial use.
https://ChefKissInc.github.io/nred
Other
1.55k stars 659 forks source link

picasso reset hang #208

Closed jalavoui closed 7 months ago

jalavoui commented 7 months ago

macOS Version

Ventura

What is your CPU's model?

ryzen 3

Please describe the behaviour in detail.

try in console (with sublime gpu aceleration enabled) + bfixup.kext

/Applications/Utilities/Sublime\ Text.app/Contents/MacOS/sublime_text

What should've happened instead?

the driver try reset and panic

possible fix: this shouldnt work for picasso but actually stops the panic

      //  if (NRed::callback->chipType >= ChipType::Renoir) {
            RouteRequestPlus request {"_psp_reset_3_1", psp12Reset, kPspReset31Pattern};
            PANIC_COND(!request.route(patcher, id, slide, size), "HWLibs", "Failed to route psp_reset_3_1");
      //  } else {
       //     RouteRequestPlus request {"_psp_reset_3_1", hwLibsUnsupported, kPspReset31Pattern};
      //      PANIC_COND(!request.route(patcher, id, slide, size), "HWLibs", "Failed to route psp_reset_3_1");
      //  }

the metal api hangs a bit as this is a extreme bug but the system recovers

If applicable, attach the .gpuRestart, .panic, etc file related to this issue.

Kernel-2023-12-07-140131.panic.zip

Bug report submission terms

VisualEhrmanntraut commented 7 months ago

This condition is impossible to be met on Picasso

VisualEhrmanntraut commented 7 months ago

Sorry, I'm at my phone while on apprenticeship and misread. The logic is based on Catalina HWLibs and Linux iirc. Not sure what Adrenaline does for this. According to them, PSP 10 does not support reset.

jalavoui commented 7 months ago

all good i saw psp 10 reset source code. maybe this hack just does nothing on picasso or maybe our picasso is just a rebranded amd.

i disabled bfixup and i'm crashing chrome to check reset recover guess no good solutions for this...

this reset issue might be important cause when vcn decoding fails the system hang (fail reset?) gonna test this with vcn decode enabled - if i get a crash i'll just revert the code

jalavoui commented 7 months ago

got a vcn decode hang. this hack didn't make vcn hang reset the gpu so i'm reverting the code

if anyone wanna replicate best app is ms edge cause it calls hw decode a lot as in this picture Captura de ecrã 2023-12-07, às 17 43 26