ChefKissInc / NootedRed

The AMD Vega iGPU support patch kext. No commercial use.
https://chefkissinc.github.io/applehax/nootedred/
Other
1.71k stars 873 forks source link

Internal display does not work in a very small amount of laptops #270

Open tlfares opened 5 months ago

tlfares commented 5 months ago

macOS Version

Ventura

What is your CPU's model?

AMD Ryzen 7 3700U with Radeon Vega 10

Please describe the behaviour in detail.

When NootedRed is enabled, only the external monitor works, and the graphics acceleration works fine. But the internal display stays completely black. The screen works when NootedRed is disabled but without GPU acceleration. I use the latest commit of NootedRed. image

What should've happened instead?

If applicable, attach the .gpuRestart, .panic, etc file related to this issue.

No response

MizuKumi commented 5 months ago

Put the laptop in sleep mode, then bring it out and see 2 active screens. Or try to activate 2 monitors via a third-party application. This is also the case with real macintosh. ¯_(ツ)_/¯

tlfares commented 5 months ago

Put the laptop in sleep mode, then bring it out and see 2 active screens. Or try to activate 2 monitors via a third-party application. This is also the case with real macintosh. ¯(ツ)

I tried but after I reopened the laptop, the laptop screen is still off :/ What third party application can I try to activate it?

tlfares commented 5 months ago

In the system report, the internal screen is not even detected, only the external monitor image

VisualEhrmanntraut commented 5 months ago

I had a bug with my workflow and the bot did not reply to the issue with the first interaction greeting:

Greetings. It seems like this is the first issue you open on this repository.

We are letting you know that these are for bug reports or feature requests. Most of the reports we receive in this GitHub Organisation are user errors.

For the sake of saving time, here are the most common cases:

  • Outdated version of this kext.
  • Conflicts with other kexts (e.g. WhateverGreen).
  • Issues caused by other kexts like memory corruption (e.g. AirportItlwm).
  • Intended behaviour by Apple (e.g. V-Sync or cursor rendering).
  • Using cheap hacks like kext/library downgrades (e.g. OCLP, BFixup).
  • Duplicate kexts.
  • Malformed config.plist caused by configurator software (OCAT, OCC, etc).
  • Lack of TSC synchronisation or use of badly programmed TSC kext (only use ForgedInvariant).
  • Outdated macOS minor version (e.g. macOS 11.0.0 instead of latest).
  • Using beta versions of macOS.
  • Using the kext during installation or update. There is a Lilu bug which makes macOS stall during the last install phase.
  • Incorrect SMBIOS. Please use iMac20,1, MacBookPro16,3, MacPro7,1 or iMacPro1,1.
  • (e)DP link training failure. -NRedDPDelay will fix this as mentioned in the README. This is last resort, black screen can be caused by other factors mentioned.
  • Insufficient VRAM size.

We will never support the use of configurator software, solutions like OCLP/BFixup, or using macOS beta versions.

This issue will be looked over by the respective maintainer when they can. In the meantime, look if you can resolve this yourself via checking the above.

Be patient, we are hobbyists.

tlfares commented 5 months ago

I had a bug with my workflow and the bot did not reply to the issue with the first interaction greeting:

Thx for your reply, I saw this in other issues threads and I already tried all of that 🥲

VisualEhrmanntraut commented 5 months ago

The greeting in the other issues is out of date in the TSC sync part.

tlfares commented 5 months ago

Yes the AmdTscSync kext is enabled

VisualEhrmanntraut commented 5 months ago

I sent the outdated text by accident. Check it again.

tlfares commented 5 months ago

Oh ok, I replaced it with ForgedInvariant but I still have the same issue

arquicion333 commented 5 months ago

Hello! I have a similar issue too. I've installed Ventura on my Dell Inspiron 3525 that works with a Ryzen 5 5625U and Radeon Vega 7. I having no luck with the internal display. It does not work, it has not signal at all most the time. I managed to end ud with the installation using and external monitor (hdmi). Ive already tried so many things. Debugs kexts, DSDT patches, etc... Some times the external display shows up as the second monitor and the internal display shows some black light. I could share my EFI or the Ioreg. The internal display is not even detected in the ioregistry. I may think it is relate to the iGPU EDID, but I just don't what to do with it. The Bios Setup of this Laptop is really basic. I'd read that it is necessary to increase the VRAM in order to have a proper performance but there is no way to change that using the bios setup. System Report shows the iGPU as Radeon Graphics 512mb. I'd checked all the stuff you marked on common cases with no luck. :(

tlfares commented 5 months ago

I'd read that it is necessary to increase the VRAM in order to have a proper performance but there is no way to change that using the bios setup.

I've tried to increase the VRAM set by the BIOS to 1 or 2Gb (using this tool https://github.com/DavidS95/Smokeless_UMAF) but that didn't changed anything for me 🥲

arquicion333 commented 5 months ago

I'd read that it is necessary to increase the VRAM in order to have a proper performance but there is no way to change that using the bios setup.

I've tried to increase the VRAM set by the BIOS to 1 or 2Gb (using this tool https://github.com/DavidS95/Smokeless_UMAF) but that didn't changed anything for me 🥲

I didn't try increasing de VRAM, because that is mostly related to the IGPU performance. This issue is related to the EDP (Embedded Display Port), or the EDID. Someone suggested me to use the Smoless_UMAF tool to change some Edp settings. I'm running the Smokeless_UMAF tool right now. At the PBS, I only have 2 options related: DP0, where I can choose EDP, DP or HDMI, and DP1, where I can choose DP or HDMI. There are no others settings related to the EDP that I can see. By default, the EDP is assigned to DP0. I guess that changing these variables won't fix the problem. And I'm a little afraid of missing the regular bios, because of the warnings related to dell's laptop users. I'd read about the fix for Dell's laptop but I found no way to delete Misc options by accessing to the tool's Boot Manager... Anyways, I think I could re-flash the chip bios with a programmer if something wrong happens.

Any ideas?

techmare commented 5 months ago

@tlfares Boot windows and go to ur task manager and then performance and then ram and check how much of your ram is reserved. If it is 2 GB then u have to 2 GB of VRAM

arquicion333 commented 5 months ago

@tlfares Boot windows and go to ur task manager and then performance and then ram and check how much of your ram is reserved. If it is 2 GB then u have to 2 GB of VRAM

Thanks, already did that! I can handle easily 4GB of VRAM cause the laptop have 16GB of RAM... Unfortunately it didn't work. I believe I have to create some special DSDT to have the EDP working, or create devices properties to address the EDID properly. I'm just burned out with this issue, but I'm not giving up. I will report myself later! Thanks, mate!

ovoME commented 5 months ago

Have you ever tried to add the dpdelay command into boot-args?

tlfares commented 5 months ago

Have you ever tried to add the dpdelay command into boot-args?

I did and nothing changed unfortunately

arquicion333 commented 5 months ago

Have you ever tried to add the dpdelay command into boot-args?

Hola amigo, Well, I did not, how would it be? I've found the internal display now, and the other connector. They go through the AMDRadeon kexts a frame buffer. But I can't figure it out how to creat a DSDT, or to make a custom EDID. Can you tell me about dp command into boot args? I will research about it. Thanks!

arquicion333 commented 5 months ago

Have you ever tried to add the dpdelay command into boot-args?

God yeah! -NRedDPDelay works flawlessly! Don't how I made it to ignore this point of the troubleshooting. It must be the devil... Muchas gracias, amigo!

tlfares commented 5 months ago

@tlfares Boot windows and go to ur task manager and then performance and then ram and check how much of your ram is reserved. If it is 2 GB then u have to 2 GB of VRAM

Yes for the dedicated GPU memory, it shows 2Gb

Trijal08 commented 3 months ago

@VisualEhrmanntraut Thank you so much for putting this request into consideration! I appreciate that!

arquicion333 commented 3 months ago

Hello, brother my brother,

I appreciate all of your workship. I also have another new laptop now, an LG Ultra 16UD70R-G.AX59B. Ryzen zen4 7000 series on it. With Vega 6 on it.

I make it work almost flawlessly, but I could not have the internal display to work properly. Black screen. The only fix so far: I have to close the display for 7 seconds, then I open it up and voila!

Many thanks for so much good work!

Cheers!

Trijal08 commented 3 months ago

@VisualEhrmanntraut I am certain that some commit(s) after this one caused and still causes the internal display issue on some AMD Radeon Vega 10 iGPU laptops. As I said in my previous problem here, I seem to recall that this commit worked for me on Ventura. However, when I tried to use an updated version of it; the internal display suddenly started showing a black screen on boot, and never stopped ever after. Also, I tried using the older build but failed to do so as it refuses to even boot any major version newer than macOS Ventura. Furthermore, I have tried to use an external display using the HDMI port with the latest 1.0.0 build, but again, failed to do so. By the way, the only time when NootedRed actually works and displays image to the internal displays is in recovery or an installation USB drive; I've confirmed that everything inlcuding graphical acceleration and HDMI output works flawlessly. I hope this helps you pinpoint and resolve this issue quicker! 😄

VisualEhrmanntraut commented 3 months ago

@Trijal08 you sending and constantly deleting that comment to make edits to it is making my computer and my phone's notifications go nuts, both on Telegram, my email, and the GitHub Mobile app. Stop!!! There's an edit button if you click the dots on the upper right of the comment.

Screenshot 2024-08-03 at 18 40 39

IMG_5270

Trijal08 commented 3 months ago

@Trijal08 you sending and constantly deleting that comment to make edits to it is making my computer and my phone's notifications go nuts, both on Telegram, my email, and the GitHub Mobile app. Stop!!! There's an edit button if you click the dots on the upper right of the comment.

Screenshot 2024-08-03 at 18 40 39

Sorry man, I didn't know that'll happen. Next time, I'll edit instead.

Trijal08 commented 3 months ago

In the system report, the internal screen is not even detected, only the external monitor image

Not even external display works for me. ☠️

VisualEhrmanntraut commented 3 months ago

@Trijal08 If the link training fails the display won't show up in settings. You mentioned there was a point where it was working. You need to find the exact commit that broke your display signal. I can't find this out myself, as mentioned in my screenshot, because I obviously don't have one of these machines.

Trijal08 commented 3 months ago

@Trijal08 If the link training fails the display won't show up in settings. You mentioned there was a point where it was working. You need to find the exact commit that broke your display signal. I can't find this out myself, as mentioned in my screenshot, because I obviously don't have one of these machines.

This: https://github.com/ChefKissInc/NootedRed/commit/86bd323c104b27988db41f2a31211d8e6465eb93 Can you maybe somehow try reverting that commit and give me the newly generated build artifacts? I would really appreciate it! However, if that doesn't work, I'll try doing something on my end and make PR in your repo if possible. I really do appreciate your work and would apprecate it even more if you could accomplish this feat!

VisualEhrmanntraut commented 3 months ago

There's no way that commit broke your display, that just moved the HDMI audio from being injected always to only on main OS.

VisualEhrmanntraut commented 3 months ago

I have some other suspicions though.

Try these builds and tell me which one works. NootedRed-1.0.0-RELEASE.zip NootedRed-1.0.0-RELEASE.zip

Trijal08 commented 3 months ago

I have some other suspicions though.

Try these builds and tell me which one works. NootedRed-1.0.0-RELEASE.zip NootedRed-1.0.0-RELEASE.zip

OMG! I FIXED IT! So basicallly I forked your repository and added those deletions back; and voila, my internal display is working like a charm and the graphics are accelerated too! Your builds didn't do shiiteza! Here is my build if you want to test it or something: https://github.com/Trijal08/NootedRed/actions/runs/10238799363 The commit I made is here: https://github.com/Trijal08/NootedRed/commit/56b47d7c73fe23b59c05bbd77550bfbec165f3f7 If you'd like, I can make a PR.

Trijal08 commented 3 months ago

There's no way that commit broke your display, that just moved the HDMI audio from being injected always to only on main OS.

Nevermind, it broke again. How sad is that!? Edit: Bruh

VisualEhrmanntraut commented 3 months ago

Yeah uh how about I just block you from the organisation instead because you are overconfident and annoying? (reader's context: he was also just as overconfident and annoying when he was in the Telegram group)

Trijal08 commented 3 months ago

Yeah uh how about I just block you from the organisation instead because you are overconfident and annoying? (reader's context: he was also just as overconfident and annoying when he was in the Telegram group)

I apologize. But how is that even possible? How does it work then it doesn't?

VisualEhrmanntraut commented 3 months ago

If your parents told you "if you do something wrong, just say sorry, it makes everything better", that's not how it works.

Trijal08 commented 3 months ago

If your parents told you "if you do something wrong, just say sorry, it makes everything better", that's not how it works.

Okay, I get it. I'll try not to be "overconfident and/or annoying" to you or somebody in this organization.

VisualEhrmanntraut commented 3 months ago

No. I suggest you chill with your internet usage and spend more time outside to improve your mental health. I don't want to handle a child having a mrbeast-type youtuber reaction to everything related to the projects. Thanks and wish you a better state of mind.

VisualEhrmanntraut commented 1 month ago

Maybe now that I put back the old brightness logic it magically fixes this issue. Can you all retry?

Kfkcome commented 1 month ago

Sir,is your external monitor connected by VGA or HDMI? When I connect external monitor by VGA ,it comes to a blue screen and cannot display anything else.

VisualEhrmanntraut commented 1 month ago

What, me? I use an M3 MacBook Pro, lol...

arquicion333 commented 1 month ago

Sir,is your external monitor connected by VGA or HDMI? When I connect external monitor by VGA ,it comes to a blue screen and cannot display anything else. Hello, VGA is an output unfamiliar for Macs, it is rarely possible to have it working.

Kfkcome commented 1 month ago

Sir,is your external monitor connected by VGA or HDMI? When I connect external monitor by VGA ,it comes to a blue screen and cannot display anything else. Hello, VGA is an output unfamiliar for Macs, it is rarely possible to have it working.

Thanks, it works fine now. I buy a new VGA to HDMI adapter.